From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98456C43461 for ; Thu, 8 Apr 2021 20:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FCEA611AD for ; Thu, 8 Apr 2021 20:53:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232331AbhDHUxS (ORCPT ); Thu, 8 Apr 2021 16:53:18 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:42735 "EHLO mail-oi1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232327AbhDHUxS (ORCPT ); Thu, 8 Apr 2021 16:53:18 -0400 Received: by mail-oi1-f174.google.com with SMTP id n140so3569290oig.9; Thu, 08 Apr 2021 13:53:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=46Uzc8wMeij8opq/aUJAyokWFKKz/7neG5XHu3unxu0=; b=OkABf1+XbWdIeQxiBdv4TAHxatiCvhmftbmC0y+lvpXxyvV9/fDBATHhVheUExRAPD I/WZxjjJa1nDGL920ynbM/kC7zcXZgw/NapAJGhPtRmQ7wAGThDxI+b8JoakI2kvci6q JHgWYHRc1OtMnfRFG8P8jc3SyZj1KMTOCPN61DOmSDSAf7lspsM3MrmNlHWu5wu4j3T9 RWLbN0Kmf236wq0iO7oJGm9eayGpT6al/D9jJTQaCo8A8c/DbYGdPnAW4d/w/E8njFeO vx9AHDRWvvkkTb812gZAgszbO0g7M2RgExxhZ3Hc7CL4PEpCrbQ1/NLFP8qMe7i01QLF tEzA== X-Gm-Message-State: AOAM532gUBCLAFqWqjPzDqMTvDFODuoEVQ7ae/nNu/hCecPNrxr1xppo Z7dLY9K6p0xHiGELoOGu98Yl3tQhfg== X-Google-Smtp-Source: ABdhPJxFrflQnRzo0BZjpJR0OEzuPqx/VjSm+Shm8/YIdpNiM0ZUQOjZ7tBjP4gmguX4T2sh1aOjGQ== X-Received: by 2002:a05:6808:1413:: with SMTP id w19mr7790722oiv.20.1617915185992; Thu, 08 Apr 2021 13:53:05 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id a13sm117398ooj.14.2021.04.08.13.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 13:53:05 -0700 (PDT) Received: (nullmailer pid 1940093 invoked by uid 1000); Thu, 08 Apr 2021 20:53:04 -0000 Date: Thu, 8 Apr 2021 15:53:04 -0500 From: Rob Herring To: satya priya Cc: Linus Walleij , Andy Gross , Bjorn Andersson , kgunda@codeaurora.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V2 3/3] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML Message-ID: <20210408205304.GA1929460@robh.at.kernel.org> References: <1617280546-9583-1-git-send-email-skakit@codeaurora.org> <1617280546-9583-4-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617280546-9583-4-git-send-email-skakit@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Apr 01, 2021 at 06:05:45PM +0530, satya priya wrote: > Convert Qualcomm PMIC GPIO bindings from .txt to .yaml format. > > Signed-off-by: satya priya > --- > Changes in V3: > - As per Rob's comments fixed bot erros. > - Moved this patch to end of the series so that other patches are not > blocked on this. > > .../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 280 -------------------- > .../bindings/pinctrl/qcom,pmic-gpio.yaml | 281 +++++++++++++++++++++ > 2 files changed, 281 insertions(+), 280 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > new file mode 100644 > index 0000000..e7e7027 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > @@ -0,0 +1,281 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/qcom,pmic-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm PMIC GPIO block > + > +maintainers: > + - Bjorn Andersson > + > +description: | > + This binding describes the GPIO block(s) found in the 8xxx series of > + PMIC's from Qualcomm. > + > +properties: > + compatible: > + items: > + - enum: > + - qcom,pm8005-gpio > + - qcom,pm8018-gpio > + - qcom,pm8038-gpio > + - qcom,pm8058-gpio > + - qcom,pm8916-gpio > + - qcom,pm8917-gpio > + - qcom,pm8921-gpio > + - qcom,pm8941-gpio > + - qcom,pm8950-gpio > + - qcom,pm8994-gpio > + - qcom,pm8998-gpio > + - qcom,pma8084-gpio > + - qcom,pmi8950-gpio > + - qcom,pmi8994-gpio > + - qcom,pmi8998-gpio > + - qcom,pms405-gpio > + - qcom,pm660-gpio > + - qcom,pm660l-gpio > + - qcom,pm8150-gpio > + - qcom,pm8150b-gpio > + - qcom,pm6150-gpio > + - qcom,pm6150l-gpio > + - qcom,pmx55-gpio > + - qcom,pm7325-gpio > + - qcom,pm8350c-gpio > + - qcom,pmk8350-gpio > + - qcom,pmr735a-gpio > + > + - enum: > + - qcom,spmi-gpio > + - qcom,ssbi-gpio Any combination of the 1st and 2nd entry is valid? > + > + reg: > + description: Register base of the GPIO block and length. Just: maxItems: 1 > + > + interrupts: > + description: | > + Must contain an array of encoded interrupt specifiers for > + each available GPIO Need to define how many interrupts. I assume there's some max. > + > + '#interrupt-cells': > + const: 2 > + > + interrupt-controller: true > + > + gpio-controller: true > + > + gpio-ranges: > + maxItems: 1 > + > + '#gpio-cells': > + const: 2 > + description: | > + The first cell will be used to define gpio number and the > + second denotes the flags for this gpio > + > + gpio-keys: > + type: object > + properties: > + volume-keys: > + type: object Needs a $ref to pinmux-node.yaml and pincfg-node.yaml. > + properties: > + pins: > + description: | > + List of gpio pins affected by the properties specified in > + this subnode. Valid pins are > + - gpio1-gpio4 for pm8005 > + - gpio1-gpio6 for pm8018 > + - gpio1-gpio12 for pm8038 > + - gpio1-gpio40 for pm8058 > + - gpio1-gpio4 for pm8916 > + - gpio1-gpio38 for pm8917 > + - gpio1-gpio44 for pm8921 > + - gpio1-gpio36 for pm8941 > + - gpio1-gpio8 for pm8950 (hole on gpio3) > + - gpio1-gpio22 for pm8994 > + - gpio1-gpio26 for pm8998 > + - gpio1-gpio22 for pma8084 > + - gpio1-gpio2 for pmi8950 > + - gpio1-gpio10 for pmi8994 > + - gpio1-gpio12 for pms405 (holes on gpio1, gpio9 > + and gpio10) > + - gpio1-gpio10 for pm8150 (holes on gpio2, gpio5, > + gpio7 and gpio8) > + - gpio1-gpio12 for pm8150b (holes on gpio3, gpio4 > + and gpio7) > + - gpio1-gpio12 for pm8150l (hole on gpio7) > + - gpio1-gpio10 for pm6150 > + - gpio1-gpio12 for pm6150l > + - gpio1-gpio10 for pm7325 > + - gpio1-gpio9 for pm8350c > + - gpio1-gpio4 for pmk8350 > + - gpio1-gpio4 for pmr735a > + > + $ref: /schemas/types.yaml#/definitions/string-array Already has a type in pinmux-node.yaml. > + items: > + pattern: "^gpio([0-9]+)$" > + > + function: > + $ref: /schemas/types.yaml#/definitions/string ditto > + description: | > + Specify the alternative function to be configured for the > + specified pins. > + items: > + - enum: > + - normal > + - paired > + - func1 > + - func2 > + - dtest1 > + - dtest2 > + - dtest3 > + - dtest4 > + - func3 # supported by LV/MV GPIO subtypes > + - func4 # supported by LV/MV GPIO subtypes > + > + bias-disable: > + $ref: /schemas/types.yaml#/definitions/flag And all these have a type and description. Just: bias-disable: true If no further constraints. > + description: > + The specified pins should be configured as no pull. > + > + bias-pull-down: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins should be configured as pull down. > + > + bias-pull-up: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins should be configured as pull up. > + > + qcom,pull-up-strength: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Specifies the strength to use for pull up, if selected. > + Valid values are defined in > + > + If this property is omitted 30uA strength will be used > + if pull up is selected > + > + bias-high-impedance: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins will put in high-Z mode and disabled. > + > + input-enable: > + $ref: /schemas/types.yaml#/definitions/flag > + description: The specified pins are put in input mode. > + > + output-high: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + The specified pins are configured in output mode, > + driven high. > + > + output-low: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + The specified pins are configured in output mode, > + driven low. > + > + power-source: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Selects the power source for the specified pins. > + Valid power sources are defined per chip in > + > + > + qcom,drive-strength: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Selects the drive strength for the specified pins > + Valid drive strength values are defined in > + > + > + drive-push-pull: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins are configured in push-pull mode. > + > + drive-open-drain: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins are configured in open-drain mode. > + > + drive-open-source: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins are configured in open-source mode. > + > + qcom,analog-pass: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + The specified pins are configured in > + analog-pass-through mode. > + > + qcom,atest: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Selects ATEST rail to route to GPIO when it's > + configured in analog-pass-through mode. > + enum: [1 2 3 4] > + > + qcom,dtest-buffer: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Selects DTEST rail to route to GPIO when it's > + configured as digital input. > + enum: [1 2 3 4] > + > + required: > + - pins > + - function > + > + additionalProperties: true > + > +additionalProperties: true Should be 'false'. > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include > + > + pm8921_gpio: gpio@150 { > + compatible = "qcom,pm8921-gpio", "qcom,ssbi-gpio"; > + reg = <0x150 0x160>; > + interrupts = <192 1>, <193 1>, <194 1>, > + <195 1>, <196 1>, <197 1>, > + <198 1>, <199 1>, <200 1>, > + <201 1>, <202 1>, <203 1>, > + <204 1>, <205 1>, <206 1>, > + <207 1>, <208 1>, <209 1>, > + <210 1>, <211 1>, <212 1>, > + <213 1>, <214 1>, <215 1>, > + <216 1>, <217 1>, <218 1>, > + <219 1>, <220 1>, <221 1>, > + <222 1>, <223 1>, <224 1>, > + <225 1>, <226 1>, <227 1>, > + <228 1>, <229 1>, <230 1>, > + <231 1>, <232 1>, <233 1>, > + <234 1>, <235 1>; > + > + gpio-controller; > + #gpio-cells = <2>; > + > + pm8921_gpio_keys: gpio-keys { > + volume-keys { > + pins = "gpio20", "gpio21"; > + function = "normal"; > + > + input-enable; > + bias-pull-up; > + drive-push-pull; > + qcom,drive-strength = ; > + power-source = ; > + }; > + }; > + }; > +... > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >