From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Ye Bin <yebin10@huawei.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()
Date: Fri, 9 Apr 2021 13:26:07 +0530 [thread overview]
Message-ID: <20210409075607.GF4376@work> (raw)
In-Reply-To: <20210409075522.2111083-1-yebin10@huawei.com>
On Fri, Apr 09, 2021 at 03:55:22PM +0800, Ye Bin wrote:
> There is a error message within devm_ioremap_resource
>
> already, so remove the dev_err call to avoid redundant
>
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/scsi/ufs/ufs-qcom.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 9b711d6aac54..2a3dd21da6a6 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1071,13 +1071,8 @@ static int ufs_qcom_init(struct ufs_hba *hba)
> if (res) {
> host->dev_ref_clk_ctrl_mmio =
> devm_ioremap_resource(dev, res);
> - if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) {
> - dev_warn(dev,
> - "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
> - __func__,
> - PTR_ERR(host->dev_ref_clk_ctrl_mmio));
> + if (IS_ERR(host->dev_ref_clk_ctrl_mmio))
> host->dev_ref_clk_ctrl_mmio = NULL;
> - }
> host->dev_ref_clk_en_mask = BIT(5);
> }
> }
>
next prev parent reply other threads:[~2021-04-09 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 7:55 [PATCH -next] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init() Ye Bin
2021-04-09 7:56 ` Manivannan Sadhasivam [this message]
2021-04-16 2:51 ` Martin K. Petersen
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409075607.GF4376@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=hulkci@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=p.zabel@pengutronix.de \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).