* [PATCH] usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe()
@ 2021-04-09 0:49 Bixuan Cui
2021-04-09 10:00 ` Manivannan Sadhasivam
0 siblings, 1 reply; 3+ messages in thread
From: Bixuan Cui @ 2021-04-09 0:49 UTC (permalink / raw)
To: linux-kernel, agross
Cc: john.wanghui, bjorn.andersson, balbi, gregkh, mgautam,
linux-arm-msm, linux-usb, Bixuan Cui
There is a error message after devm_ioremap_resource failed, and the ret
is needs to be obtained through PTR_ERR(qcom->qscratch_base).
We need to move the dev_err() downwards to ensure that the ret value is
correct.
Fixes: a4333c3a6ba9 ('usb: dwc3: Add Qualcomm DWC3 glue driver')
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
drivers/usb/dwc3/dwc3-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
index e37cc58dfa55..4716ca8c753d 100644
--- a/drivers/usb/dwc3/dwc3-qcom.c
+++ b/drivers/usb/dwc3/dwc3-qcom.c
@@ -774,8 +774,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
qcom->qscratch_base = devm_ioremap_resource(dev, parent_res);
if (IS_ERR(qcom->qscratch_base)) {
- dev_err(dev, "failed to map qscratch, err=%d\n", ret);
ret = PTR_ERR(qcom->qscratch_base);
+ dev_err(dev, "failed to map qscratch, err=%d\n", ret);
goto clk_disable;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe()
2021-04-09 0:49 [PATCH] usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe() Bixuan Cui
@ 2021-04-09 10:00 ` Manivannan Sadhasivam
2021-04-10 1:58 ` Bixuan Cui
0 siblings, 1 reply; 3+ messages in thread
From: Manivannan Sadhasivam @ 2021-04-09 10:00 UTC (permalink / raw)
To: Bixuan Cui
Cc: linux-kernel, agross, john.wanghui, bjorn.andersson, balbi,
gregkh, mgautam, linux-arm-msm, linux-usb
On Fri, Apr 09, 2021 at 08:49:45AM +0800, Bixuan Cui wrote:
> There is a error message after devm_ioremap_resource failed, and the ret
> is needs to be obtained through PTR_ERR(qcom->qscratch_base).
> We need to move the dev_err() downwards to ensure that the ret value is
> correct.
>
> Fixes: a4333c3a6ba9 ('usb: dwc3: Add Qualcomm DWC3 glue driver')
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index e37cc58dfa55..4716ca8c753d 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -774,8 +774,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>
> qcom->qscratch_base = devm_ioremap_resource(dev, parent_res);
> if (IS_ERR(qcom->qscratch_base)) {
> - dev_err(dev, "failed to map qscratch, err=%d\n", ret);
> ret = PTR_ERR(qcom->qscratch_base);
> + dev_err(dev, "failed to map qscratch, err=%d\n", ret);
But this error message can be removed altogether as devm_ioremap_resource()
reports it already.
Thanks,
Mani
> goto clk_disable;
> }
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe()
2021-04-09 10:00 ` Manivannan Sadhasivam
@ 2021-04-10 1:58 ` Bixuan Cui
0 siblings, 0 replies; 3+ messages in thread
From: Bixuan Cui @ 2021-04-10 1:58 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: linux-kernel, agross, john.wanghui, bjorn.andersson, balbi,
gregkh, mgautam, linux-arm-msm, linux-usb
On 2021/4/9 18:00, Manivannan Sadhasivam wrote:
> But this error message can be removed altogether as devm_ioremap_resource()
> reports it already.
Thank you for your reply. I'll revise it.
Thanks,
Bixuan Cui
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-10 1:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 0:49 [PATCH] usb: dwc3: qcom: Fixed an issue that the ret value is incorrect in dwc3_qcom_probe() Bixuan Cui
2021-04-09 10:00 ` Manivannan Sadhasivam
2021-04-10 1:58 ` Bixuan Cui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).