linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Guru Das Srinagesh <gurus@codeaurora.org>,
	Lee Jones <lee.jones@linaro.org>,
	devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: mfd: pm8008: Add IRQ listing
Date: Fri, 9 Apr 2021 13:56:27 -0500	[thread overview]
Message-ID: <20210409185627.GA3956543@robh.at.kernel.org> (raw)
In-Reply-To: <20210409155519.GX904837@yoga>

On Fri, Apr 09, 2021 at 10:55:19AM -0500, Bjorn Andersson wrote:
> On Thu 08 Apr 19:38 CDT 2021, Guru Das Srinagesh wrote:
> 
> > Add a header file listing all of the IRQs that Qualcomm Technologies,
> > Inc. PM8008 supports. The constants defined in this file may be used in
> > the client device tree node to specify interrupts.
> > 
> > Change-Id: I13fb096da54458f2882e8d853a3ad9c379e7d5a9
> 
> Please remember to drop the Change-Id when posting to the mailing lists.
> 
> 
> We typically don't have defines for the IRQ numbers, but I don't mind.

But I do because then others will think it's a good idea.

> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> 
> Regards,
> Bjorn
> 
> > Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> > ---
> >  include/dt-bindings/mfd/qcom-pm8008.h | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >  create mode 100644 include/dt-bindings/mfd/qcom-pm8008.h
> > 
> > diff --git a/include/dt-bindings/mfd/qcom-pm8008.h b/include/dt-bindings/mfd/qcom-pm8008.h
> > new file mode 100644
> > index 0000000..eca9448
> > --- /dev/null
> > +++ b/include/dt-bindings/mfd/qcom-pm8008.h
> > @@ -0,0 +1,19 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Copyright (c) 2021 The Linux Foundation. All rights reserved.
> > + */
> > +
> > +#ifndef __DT_BINDINGS_MFD_QCOM_PM8008_H
> > +#define __DT_BINDINGS_MFD_QCOM_PM8008_H
> > +
> > +/* PM8008 IRQ numbers */
> > +#define PM8008_IRQ_MISC_UVLO	0
> > +#define PM8008_IRQ_MISC_OVLO	1
> > +#define PM8008_IRQ_MISC_OTST2	2
> > +#define PM8008_IRQ_MISC_OTST3	3
> > +#define PM8008_IRQ_MISC_LDO_OCP	4
> > +#define PM8008_IRQ_TEMP_ALARM	5
> > +#define PM8008_IRQ_GPIO1	6
> > +#define PM8008_IRQ_GPIO2	7
> > +
> > +#endif
> > -- 
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> > 

  reply	other threads:[~2021-04-09 18:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  0:38 [PATCH 0/3] Add Qualcomm Technologies, Inc. PM8008 MFD driver Guru Das Srinagesh
2021-04-09  0:38 ` [PATCH 1/3] dt-bindings: mfd: pm8008: Add IRQ listing Guru Das Srinagesh
2021-04-09 15:55   ` Bjorn Andersson
2021-04-09 18:56     ` Rob Herring [this message]
2021-04-09  0:38 ` [PATCH 2/3] dt-bindings: mfd: pm8008: Add bindings Guru Das Srinagesh
2021-04-09 14:20   ` Rob Herring
2021-04-09  0:38 ` [PATCH 3/3] mfd: pm8008: Add driver for QCOM PM8008 PMIC Guru Das Srinagesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409185627.GA3956543@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gurus@codeaurora.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).