From: Rob Herring <robh@kernel.org>
To: Guru Das Srinagesh <gurus@codeaurora.org>
Cc: Lee Jones <lee.jones@linaro.org>,
devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: mfd: pm8008: Add bindings
Date: Mon, 12 Apr 2021 14:37:48 -0500 [thread overview]
Message-ID: <20210412193748.GA53049@robh.at.kernel.org> (raw)
In-Reply-To: <787cb004e6e7db766f68cb7ace9028c37085088a.1618015804.git.gurus@codeaurora.org>
On Fri, Apr 09, 2021 at 05:55:01PM -0700, Guru Das Srinagesh wrote:
> Add bindings for the Qualcomm Technologies, Inc. PM8008 MFD driver.
>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> ---
> .../devicetree/bindings/mfd/qcom,pm8008.yaml | 119 +++++++++++++++++++++
> 1 file changed, 119 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> new file mode 100644
> index 0000000..0cafa98
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> @@ -0,0 +1,119 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/qcom,pm8008.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. PM8008 PMIC bindings
> +
> +maintainers:
> + - Guru Das Srinagesh <gurus@codeaurora.org>
> +
> +description: |
> + Qualcomm Technologies, Inc. PM8008 is a dedicated camera PMIC that integrates
> + all the necessary power management, housekeeping, and interface support
> + functions into a single IC.
> +
> +properties:
> + compatible:
> + const: qcom,pm8008
> +
> + reg:
> + description:
> + I2C slave address.
> +
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + description: Parent interrupt.
> +
> + "#interrupt-cells":
> + const: 2
> +
> + description: |
> + The first cell is the IRQ number, the second cell is the IRQ trigger
> + flag. All interrupts are listed in include/dt-bindings/mfd/qcom-pm8008.h.
> +
> + interrupt-controller: true
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> +patternProperties:
> + "^pinctrl@[0-9a-f]+$":
Doesn't look like a pin controller. 'gpio@...' instead.
> + type: object
additionalProperties: false
> +
> + description: |
> + The GPIO peripheral. This node may be specified twice, one for each GPIO.
> +
> + properties:
> + compatible:
> + const: qcom,pm8008-gpio
> +
> + reg:
> + description: Peripheral address of one of the two GPIO peripherals.
> + maxItems: 1
> +
> + gpio-controller: true
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> +
> + "#gpio-cells":
> + const: 2
> +
> + required:
> + - compatible
> + - reg
> + - gpio-controller
> + - interrupt-controller
> + - "#gpio-cells"
> + - "#interrupt-cells"
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#address-cells"
> + - "#size-cells"
> + - "#interrupt-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/mfd/qcom-pm8008.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + qupv3_se13_i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pm8008i@8 {
> + compatible = "qcom,pm8008";
> + reg = <0x8>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <32 IRQ_TYPE_EDGE_RISING>;
> +
> + pinctrl@c000 {
> + compatible = "qcom,pm8008-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> + };
> +
> +...
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2021-04-12 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 0:54 [PATCH v2 0/3] Add Qualcomm Technologies, Inc. PM8008 MFD driver Guru Das Srinagesh
2021-04-10 0:55 ` [PATCH v2 1/3] dt-bindings: mfd: pm8008: Add IRQ listing Guru Das Srinagesh
2021-04-12 19:36 ` Rob Herring
2021-04-10 0:55 ` [PATCH v2 2/3] dt-bindings: mfd: pm8008: Add bindings Guru Das Srinagesh
2021-04-12 19:37 ` Rob Herring [this message]
2021-04-13 1:52 ` Guru Das Srinagesh
2021-04-10 0:55 ` [PATCH v2 3/3] mfd: pm8008: Add driver for QCOM PM8008 PMIC Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412193748.GA53049@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gurus@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).