From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>, Andy Gross <agross@kernel.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel
Date: Mon, 12 Apr 2021 14:02:45 -0600 [thread overview]
Message-ID: <20210412200245.GB582352@xps15> (raw)
In-Reply-To: <20210323122737.23035-1-arnaud.pouliquen@foss.st.com>
On Tue, Mar 23, 2021 at 01:27:30PM +0100, Arnaud Pouliquen wrote:
> This series is the second step in the division of the series [1]:
> "Introducing a Generic IOCTL Interface for RPMsg Channel Management".
>
> The purpose of this patchset is to:
> - split the control code related to the control
> and the endpoint.
> - define the rpmsg-raw channel, associated with the rpmsg char device to
> allow it to be instantiated using a name service announcement.
>
> An important point to keep in mind for this patchset is that the concept of
> channel is associated with a default endpoint. To facilitate communication
> with the remote side, this default endpoint must have a fixed address.
>
> Consequently, for this series, I made a design choice to fix the endpoint
> on the "rpmsg-raw" channel probe, and not allow to create/destroy an endpoint
> on FS open/close.
>
> This is only applicable for channels probed by the rpmsg bus. The behavior,
> using the RPMSG_CREATE_EPT_IOCTL and RPMSG_DESTROY_EPT_IOCTL controls, is
> preserved.
>
> The next steps should be to correct this:
> Introduce the IOCTLs RPMSG_CREATE_DEV_IOCTL and RPMSG_DESTROY_DEV_IOCTL
> to instantiate the rpmsg devices
>
> [1]: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=435523
>
> Arnaud Pouliquen (7):
> rpmsg: char: Export eptdev create an destroy functions
> rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl
> rpmsg: Update rpmsg_chrdev_register_device function
> rpmsg: char: Introduce __rpmsg_chrdev_create_eptdev function
> rpmsg: char: Introduce a rpmsg driver for the rpmsg char device
> rpmsg: char: No dynamic endpoint management for the default one
> rpmsg: char: Return error if user try to destroy a default endpoint.
>
I am done reviewing this set.
Thanks,
Mathieu
> drivers/rpmsg/Kconfig | 9 ++
> drivers/rpmsg/Makefile | 1 +
> drivers/rpmsg/qcom_glink_native.c | 2 +-
> drivers/rpmsg/qcom_smd.c | 2 +-
> drivers/rpmsg/rpmsg_char.c | 221 +++++++++-------------------
> drivers/rpmsg/rpmsg_char.h | 50 +++++++
> drivers/rpmsg/rpmsg_ctrl.c | 233 ++++++++++++++++++++++++++++++
> drivers/rpmsg/rpmsg_internal.h | 8 +-
> drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
> 9 files changed, 368 insertions(+), 160 deletions(-)
> create mode 100644 drivers/rpmsg/rpmsg_char.h
> create mode 100644 drivers/rpmsg/rpmsg_ctrl.c
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-04-12 20:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 12:27 [PATCH 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel Arnaud Pouliquen
2021-03-23 12:27 ` [PATCH 1/7] rpmsg: char: Export eptdev create an destroy functions Arnaud Pouliquen
2021-03-23 12:27 ` [PATCH 2/7] rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl Arnaud Pouliquen
2021-04-09 17:36 ` Mathieu Poirier
2021-03-23 12:27 ` [PATCH 3/7] rpmsg: Update rpmsg_chrdev_register_device function Arnaud Pouliquen
2021-03-23 12:27 ` [PATCH 4/7] rpmsg: char: Introduce __rpmsg_chrdev_create_eptdev function Arnaud Pouliquen
2021-04-09 17:53 ` Mathieu Poirier
2021-03-23 12:27 ` [PATCH 5/7] rpmsg: char: Introduce a rpmsg driver for the rpmsg char device Arnaud Pouliquen
2021-04-12 19:53 ` Mathieu Poirier
2021-03-23 12:27 ` [PATCH 6/7] rpmsg: char: No dynamic endpoint management for the default one Arnaud Pouliquen
2021-03-23 12:27 ` [PATCH 7/7] rpmsg: char: Return error if user try to destroy a default endpoint Arnaud Pouliquen
2021-04-12 20:02 ` Mathieu Poirier [this message]
2021-04-13 7:02 ` [PATCH 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412200245.GB582352@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=agross@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).