archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <>
To: Loic Poulain <>
Subject: Re: [PATCH net-next v10 1/2] net: Add a WWAN subsystem
Date: Tue, 13 Apr 2021 11:27:51 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, 12 Apr 2021 21:23:06 +0200 Loic Poulain wrote:
> This change introduces initial support for a WWAN framework. Given the
> complexity and heterogeneity of existing WWAN hardwares and interfaces,
> there is no strict definition of what a WWAN device is and how it should
> be represented. It's often a collection of multiple devices that perform
> the global WWAN feature (netdev, tty, chardev, etc).
> One usual way to expose modem controls and configuration is via high
> level protocols such as the well known AT command protocol, MBIM or
> QMI. The USB modems started to expose them as character devices, and
> user daemons such as ModemManager learnt to use them.
> This initial version adds the concept of WWAN port, which is a logical
> pipe to a modem control protocol. The protocols are rawly exposed to
> user via character device, allowing straigthforward support in existing
> tools (ModemManager, ofono...). The WWAN core takes care of the generic
> part, including character device management, and relies on port driver
> operations to receive/submit protocol data.
> Since the different devices exposing protocols for a same WWAN hardware
> do not necessarily know about each others (e.g. two different USB
> interfaces, PCI/MHI channel devices...) and can be created/removed in
> different orders, the WWAN core ensures that all WAN ports contributing
> to the 'whole' WWAN feature are grouped under the same virtual WWAN
> device, relying on the provided parent device (e.g. mhi controller,
> USB device). It's a 'trick' I copied from Johannes's earlier WWAN
> subsystem proposal.
> This initial version is purposely minimalist, it's essentially moving
> the generic part of the previously proposed mhi_wwan_ctrl driver inside
> a common WWAN framework, but the implementation is open and flexible
> enough to allow extension for further drivers.
> Signed-off-by: Loic Poulain <>

> +/**
> + * enum wwan_port_type - WWAN port types
> + * @WWAN_PORT_AT: AT commands
> + * @WWAN_PORT_MBIM: Mobile Broadband Interface Model control
> + * @WWAN_PORT_QMI: Qcom modem/MSM interface for modem control
> + * @WWAN_PORT_QCDM: Qcom Modem diagnostic interface
> + * @WWAN_PORT_FIREHOSE: XML based command protocol
> + */
> +enum wwan_port_type {
> +};

include/linux/wwan.h:28: warning: Enum value 'WWAN_PORT_MAX' not described in enum 'wwan_port_type'

      parent reply	other threads:[~2021-04-13 18:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 19:23 [PATCH net-next v10 1/2] net: Add a WWAN subsystem Loic Poulain
2021-04-12 19:23 ` [PATCH net-next v10 2/2] net: Add Qcom WWAN control driver Loic Poulain
2021-04-13 18:27 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).