* [PATCH v3 1/1] nexus: Fix gpio-reserved-ranges 85-88
@ 2021-04-15 17:39 Petr Vorel
2021-04-15 18:47 ` Konrad Dybcio
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2021-04-15 17:39 UTC (permalink / raw)
To: linux-arm-msm
Cc: Petr Vorel, Andy Gross, Bjorn Andersson, Rob Herring,
Ricardo Ribalda, Linus Walleij, Konrad Dybcio, devicetree
Reserve GPIO pins 85-88 as these aren't meant to be accessible from the
application CPUs (causes reboot). Yet another fix similar to
9134586715e3, 5f8d3ab136d0, which is needed to allow angler to boot after
3edfb7bd76bd ("gpiolib: Show correct direction from the beginning").
Fixes: feeaf56ac78d ("arm64: dts: msm8994 SoC and Huawei Angler (Nexus 6P) support")
Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Hi,
NOTE: as I wrote there is also problem with 86588296acbf ("fdt: Properly
handle "no-map" field in the memory region") from v5.12-rc1-dontuse, but
that's another story.
Kind regards,
Petr
arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
index baa55643b40f..ffe1a9bd8f70 100644
--- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
+++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
@@ -32,3 +32,7 @@ serial@f991e000 {
};
};
};
+
+&tlmm {
+ gpio-reserved-ranges = <85 4>;
+};
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/1] nexus: Fix gpio-reserved-ranges 85-88
2021-04-15 17:39 [PATCH v3 1/1] nexus: Fix gpio-reserved-ranges 85-88 Petr Vorel
@ 2021-04-15 18:47 ` Konrad Dybcio
2021-04-15 19:36 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2021-04-15 18:47 UTC (permalink / raw)
To: Petr Vorel, linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Ricardo Ribalda,
Linus Walleij, devicetree
Hi,
the patch title should be:
arm64: dts: qcom: angler: <blurb>
or
arm64: dts: qcom: msm8994-angler:
But that's a nit, that could probably be fixed when applying. Otherwise, if the device now works:
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/1] nexus: Fix gpio-reserved-ranges 85-88
2021-04-15 18:47 ` Konrad Dybcio
@ 2021-04-15 19:36 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2021-04-15 19:36 UTC (permalink / raw)
To: Konrad Dybcio
Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Rob Herring,
Ricardo Ribalda, Linus Walleij, devicetree
Hi Konrad,
> Hi,
> the patch title should be:
> arm64: dts: qcom: angler: <blurb>
> or
> arm64: dts: qcom: msm8994-angler:
I'm sorry for this error, I'll send v4. Thanks for spotting this.
> But that's a nit, that could probably be fixed when applying. Otherwise, if the device now works:
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Well, as I wrote, it works till 86588296acbf (from v5.12-rc1-dontuse), which
will take me some time to figure out why. But this commit is valid, thus I dare
to add your Reviewed-by in that v4.
Kind regards,
Petr
> Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-15 19:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 17:39 [PATCH v3 1/1] nexus: Fix gpio-reserved-ranges 85-88 Petr Vorel
2021-04-15 18:47 ` Konrad Dybcio
2021-04-15 19:36 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).