Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN
@ 2021-04-21  6:55 Jarvis Jiang
  2021-04-28  8:38 ` Loic Poulain
  0 siblings, 1 reply; 3+ messages in thread
From: Jarvis Jiang @ 2021-04-21  6:55 UTC (permalink / raw)
  To: mani, hemantk
  Cc: linux-kernel, linux-arm-msm, cchen50, mpearson, Jarvis Jiang

According to MHI v1.1 specification, change the channel name of T99W175
from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33,
so that the channels can be bound to the Qcom WWAN control driver, and
device node such as /dev/wwan0p3AT will be generated, which is very useful
for debugging modem

Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>
---
 drivers/bus/mhi/pci_generic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 7c810f02a2ef..8c7f6576e421 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -311,8 +311,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
 	MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
 	MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
 	MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
-	MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0),
-	MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0),
+	MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
+	MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
 	MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
 	MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
 };
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN
  2021-04-21  6:55 [PATCH v1] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN Jarvis Jiang
@ 2021-04-28  8:38 ` Loic Poulain
  2021-04-29  1:22   ` Jarvis Jiang
  0 siblings, 1 reply; 3+ messages in thread
From: Loic Poulain @ 2021-04-28  8:38 UTC (permalink / raw)
  To: Jarvis Jiang
  Cc: Manivannan Sadhasivam, Hemant Kumar, open list, linux-arm-msm,
	Chi-Wei Chen50, Mark Pearson

On Wed, 21 Apr 2021 at 08:56, Jarvis Jiang <jarvis.w.jiang@gmail.com> wrote:
>
> According to MHI v1.1 specification, change the channel name of T99W175
> from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33,
> so that the channels can be bound to the Qcom WWAN control driver, and
> device node such as /dev/wwan0p3AT will be generated, which is very useful
> for debugging modem
>
> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>

Ok, it seems the spec claims it's a DUN channel, but all vendors use
it for AT protocol, so it's fine (and correctly handled by the
mhi_wwan_ctrl driver).

Could you please add a Fixes tag since it fixes your previous commit?

with that

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>



> ---
>  drivers/bus/mhi/pci_generic.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 7c810f02a2ef..8c7f6576e421 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -311,8 +311,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
>         MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
>         MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
>         MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> -       MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0),
> -       MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0),
> +       MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> +       MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
>         MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
>         MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>  };
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN
  2021-04-28  8:38 ` Loic Poulain
@ 2021-04-29  1:22   ` Jarvis Jiang
  0 siblings, 0 replies; 3+ messages in thread
From: Jarvis Jiang @ 2021-04-29  1:22 UTC (permalink / raw)
  To: Loic Poulain
  Cc: Manivannan Sadhasivam, Hemant Kumar, open list, linux-arm-msm,
	Chi-Wei Chen50, Mark Pearson

On Wed, Apr 28, 2021 at 4:30 PM Loic Poulain <loic.poulain@linaro.org> wrote:
>
> On Wed, 21 Apr 2021 at 08:56, Jarvis Jiang <jarvis.w.jiang@gmail.com> wrote:
> >
> > According to MHI v1.1 specification, change the channel name of T99W175
> > from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33,
> > so that the channels can be bound to the Qcom WWAN control driver, and
> > device node such as /dev/wwan0p3AT will be generated, which is very useful
> > for debugging modem
> >
> > Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>
>
> Ok, it seems the spec claims it's a DUN channel, but all vendors use
> it for AT protocol, so it's fine (and correctly handled by the
> mhi_wwan_ctrl driver).
>
> Could you please add a Fixes tag since it fixes your previous commit?
>

Sure, I will add it in the next patch.

thanks,
Jarvis

> with that
>
> Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
>
>
>
> > ---
> >  drivers/bus/mhi/pci_generic.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> > index 7c810f02a2ef..8c7f6576e421 100644
> > --- a/drivers/bus/mhi/pci_generic.c
> > +++ b/drivers/bus/mhi/pci_generic.c
> > @@ -311,8 +311,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
> >         MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
> >         MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
> >         MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> > -       MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0),
> > -       MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0),
> > +       MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> > +       MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> >         MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> >         MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> >  };
> > --
> > 2.25.1
> >

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21  6:55 [PATCH v1] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN Jarvis Jiang
2021-04-28  8:38 ` Loic Poulain
2021-04-29  1:22   ` Jarvis Jiang

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git