From: Mark Brown <broonie@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, robh@kernel.org, devicetree@vger.kernel.org,
wcheng@codeaurora.org, linux-arm-msm@vger.kernel.org,
dmitry.baryshkov@linaro.org
Subject: Re: [PATCH v2 2/2] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster
Date: Tue, 27 Apr 2021 12:27:12 +0100 [thread overview]
Message-ID: <20210427112712.GG4605@sirena.org.uk> (raw)
In-Reply-To: <20210426221446.1852572-3-bryan.odonoghue@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On Mon, Apr 26, 2021 at 11:14:46PM +0100, Bryan O'Donoghue wrote:
> --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> @@ -53,6 +53,14 @@ power-on@800 {
> status = "disabled";
> };
>
> + pm8150b_vbus: dcdc@1100 {
> + compatible = "qcom,pm8150b-vbus-reg";
> + regulator-min-microamp = <500000>;
> + regulator-max-microamp = <3000000>;
> + status = "disabled";
> + reg = <0x1100>;
> + };
This appears to be a generic .dtsi for any system with this device, it's
very much not idiomatic to be setting regulator constraints that allow
things to be changed like this by default (even though the board does
need to explicitly opt in to having the device).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-27 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 22:14 [PATCH v2 0/2] Enable VBUS current boost on pm8150b platforms Bryan O'Donoghue
2021-04-26 22:14 ` [PATCH v2 1/2] regulator: Add a routine to set the current limit for QCOM PMIC VBUS Bryan O'Donoghue
2021-04-26 22:14 ` [PATCH v2 2/2] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster Bryan O'Donoghue
2021-04-27 11:27 ` Mark Brown [this message]
2021-05-11 8:25 ` (subset) [PATCH v2 0/2] Enable VBUS current boost on pm8150b platforms Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210427112712.GG4605@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).