From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA26C433ED for ; Tue, 27 Apr 2021 16:56:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 190B5613D9 for ; Tue, 27 Apr 2021 16:56:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236169AbhD0Q5J (ORCPT ); Tue, 27 Apr 2021 12:57:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236485AbhD0Q5A (ORCPT ); Tue, 27 Apr 2021 12:57:00 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52113C061756 for ; Tue, 27 Apr 2021 09:56:15 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id v23-20020a9d60570000b02902a53bac99a3so1127369otj.5 for ; Tue, 27 Apr 2021 09:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=QRk2LvR9iUeYUREemfpr9zlZCwG60wzOzlEIrhDF+Sg=; b=Mg+t1ygXrSkyxRN21CcAGfN2N/VQdb4dgdgUfkavIbfI2gQgU7S8Nbe51ZwxofMVDU DYxBPwjRWZ9tS+Ug6DYhw2NAiUv7Uslduh4g+ydfGiIYOYTm/odkCkywuPwLZvHhj001 Nj76hMs3eS3KfwykOKdI2OhQ9LHIhLJEa84Ta/11rYHscKb0aXmkdvrQWm8lFW9/FG8q nAyilNN4zPagDYfM4X7VhKJ1MgX3WwBwb1a6EpknAj709oogxffAOByohP4Q44tOELnZ bffkB0gpXwabU1fluAFKfXzyPFet69d8VhnZp1pwISPsVuVy1ffFomb3a2pu7YyCEwsj R44w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=QRk2LvR9iUeYUREemfpr9zlZCwG60wzOzlEIrhDF+Sg=; b=LntPBvQ/R70IjwAp033s5ByI08yuSRy9DqjAwn9qqis2319dfUo2iQ45norjvTSaeB kYDQzspff3IVLtk2dmp0KkkNLfRwpdGBmI70/PAz11KGeT+iqj/dEYyh2CSiZO39TlIs CKUlDn8Ihwx8fsImD4J14FG6E2Y8rLLLRnmR+YbknV7dFxD3u/jayvg2+SX1p6G8RNY2 05CjRq+KR9CQjWGBdxJ0EcIRBcsLC+QvdIZ2UUVewHpzVBB/d0BMZgS5cZtGw+W2WS5J bKL0QayyYueni46TInQ311dAPz/jAIp+CrzYQaGEMInJfzID4+4t7CYtedTmD3PjsEDB 038w== X-Gm-Message-State: AOAM530p2vMi0KD8L5UZImJjmg0QfvkpV2KcnMBAYAa/V/eF1efZpm6u P7/m557TvYpqKZV8jtT6UUfYbHg13fLQVA== X-Google-Smtp-Source: ABdhPJx6aYECW2V68OVpAtpfvKHO13slnZFmPrq/7DqZK4gwjAfbgfVW4NSwSDtRTK5yExrvhCPV2g== X-Received: by 2002:a05:6830:2004:: with SMTP id e4mr20470372otp.78.1619542574606; Tue, 27 Apr 2021 09:56:14 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id q189sm90658oih.25.2021.04.27.09.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 09:56:14 -0700 (PDT) Date: Tue, 27 Apr 2021 11:56:12 -0500 From: Bjorn Andersson To: Uwe Kleine-K?nig Cc: Andy Gross , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: qcom: Simplify usage of dev_err_probe() Message-ID: <20210427165612.GH1908499@yoga> References: <20210427164522.2886825-1-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210427164522.2886825-1-uwe@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 27 Apr 11:45 CDT 2021, Uwe Kleine-K?nig wrote: > dev_err_probe() returns the error code passed as second parameter. Also if > the error code is -EPROBE_DEFER dev_err_probe() is silent, so there is no > need to check for this value before calling dev_err_probe(). > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Uwe Kleine-König > --- > drivers/clk/qcom/apcs-sdx55.c | 22 ++++++++-------------- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/drivers/clk/qcom/apcs-sdx55.c b/drivers/clk/qcom/apcs-sdx55.c > index d0edabebf9c2..6810637f32e3 100644 > --- a/drivers/clk/qcom/apcs-sdx55.c > +++ b/drivers/clk/qcom/apcs-sdx55.c > @@ -56,10 +56,8 @@ static int qcom_apcs_sdx55_clk_probe(struct platform_device *pdev) > int ret; > > regmap = dev_get_regmap(parent, NULL); > - if (!regmap) { > - dev_err_probe(dev, -ENODEV, "Failed to get parent regmap\n"); > - return -ENODEV; > - } > + if (!regmap) > + return dev_err_probe(dev, -ENODEV, "Failed to get parent regmap\n"); > > a7cc = devm_kzalloc(dev, sizeof(*a7cc), GFP_KERNEL); > if (!a7cc) > @@ -80,19 +78,15 @@ static int qcom_apcs_sdx55_clk_probe(struct platform_device *pdev) > a7cc->parent_map = apcs_mux_clk_parent_map; > > a7cc->pclk = devm_clk_get(parent, "pll"); > - if (IS_ERR(a7cc->pclk)) { > - ret = PTR_ERR(a7cc->pclk); > - if (ret != -EPROBE_DEFER) > - dev_err_probe(dev, ret, "Failed to get PLL clk\n"); > - return ret; > - } > + if (IS_ERR(a7cc->pclk)) > + return dev_err_probe(dev, PTR_ERR(a7cc->pclk), > + "Failed to get PLL clk\n"); > > a7cc->clk_nb.notifier_call = a7cc_notifier_cb; > ret = clk_notifier_register(a7cc->pclk, &a7cc->clk_nb); > - if (ret) { > - dev_err_probe(dev, ret, "Failed to register clock notifier\n"); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, > + "Failed to register clock notifier\n"); > > ret = devm_clk_register_regmap(dev, &a7cc->clkr); > if (ret) { > -- > 2.30.2 >