From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BED4C433ED for ; Fri, 7 May 2021 17:07:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A64E61463 for ; Fri, 7 May 2021 17:07:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235840AbhEGRIe (ORCPT ); Fri, 7 May 2021 13:08:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238505AbhEGRId (ORCPT ); Fri, 7 May 2021 13:08:33 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 587A3C061574 for ; Fri, 7 May 2021 10:07:31 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id cl24-20020a17090af698b0290157efd14899so5681698pjb.2 for ; Fri, 07 May 2021 10:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RiGyUlYAW1u/8xTEb2M57YXe98Wsy6SGD0Ef+9dzg2k=; b=zXQbNUSKr6WntaFyoibLr+KI6HA/xr8Y8FL4frv3mk1pziMaor2RgvdJxyXYG+V2u+ 0o37nxLDo6ReRvnYGpdFzA4iSIAYvvzPHXqqbs6ahWb1WVMgDPHfaFI304x2txId9w1m 1n+cimEpErDy+cXQ6MBj2W7m3VLC9nxKcHSBiBVPsmj3ZuLbjHASw7tiCO2IWzBJhCFc fT5sEFMPT3buMA4fyMIv0YO3lgPXVR8Q1G86XU4oGhS3ElYr3rnjGuEcoBs7+Xsf6WGL bBbH60nl7ziBQbnBdhIO7opxW1beGWPhOahXcKrgDRQUHpmFjteuHbEskM+vYsg5s+6F XPKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RiGyUlYAW1u/8xTEb2M57YXe98Wsy6SGD0Ef+9dzg2k=; b=fFwqy2DwOTzvasC3hTMZs7+QGflaAIY0+FgT1ZvASaY6Mz5jCNBt8Lz/1qiuMK26tP 1/bvCD0Zycvs+z/uh8P5R5da6A+n0b5C6gzsXocnHK6SbWOtDIXa5SUrXwz3iNgLTqqI OQ9DraxCNqPSJmcOtQjYRJ4S8oTZ6ctxHwg0y0IK4UK1Mvp/hyzRODojHUE8y/FXhxIX 74HFCGn77RJNqwZmo+TFjMGxsigLK/f1iSCH1CBIiGsQKu1izlTzuR3tKGYrYttOXF93 vTNliYvzv6p/lRqf/FpyOEdZPbH+8mXEHx0408A0WTvgaeE/IjbIF9qRc1dxSgN2CEk3 T3QA== X-Gm-Message-State: AOAM5318jiYdfkocYVaZ36GCgxmu8FPjQwV9AdpUIeoy6V910LGd6r/a nCt6cG4Cbu4vCO2lJl71xaK9 X-Google-Smtp-Source: ABdhPJyuPKTcZCWMAOt39RYL09MRviRjAJXantrTkcrhT5nEDL3ejQXsOJOUnbZ/LZQFdAgX5bckWg== X-Received: by 2002:a17:90b:3615:: with SMTP id ml21mr24188974pjb.28.1620407250646; Fri, 07 May 2021 10:07:30 -0700 (PDT) Received: from thinkpad ([2409:4072:e94:6cb6:4728:f123:8d88:45e9]) by smtp.gmail.com with ESMTPSA id n189sm3415486pfn.10.2021.05.07.10.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 10:07:30 -0700 (PDT) Date: Fri, 7 May 2021 22:37:22 +0530 From: Manivannan Sadhasivam To: Konrad Dybcio Cc: Yassine Oudjana , Andy Gross , Bjorn Andersson , Rob Herring , Ohad Ben-Cohen , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH 1/3] remoteproc: qcom: pas: Use the same init resources for MSM8996 and MSM8998 Message-ID: <20210507170722.GB3919@thinkpad> References: <20210507164045.GA3622@thinkpad> <22accfef-a629-b483-f93f-820030ff5189@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22accfef-a629-b483-f93f-820030ff5189@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, May 07, 2021 at 06:56:22PM +0200, Konrad Dybcio wrote: > Hi, > > > > NACK. > > > > I see that the "slpi_resource_init" and "msm8998_{slpi/adsp}_resource" are > > completely different, even the firmware name. How can you get it to work? > > one of us must be looking at some knock-off source code, as they are identical say for the presence or absence of proxy_pd_names, which are required for 8996 and weren't really an exposed thing on old SoCs like 8974. > Actually "msm8998_adsp_resource" is what different from "slpi_resource_init" and "msm8998_slpi_resource" looks good. So you can just add the proxy votes to "slpi_resource_init". Thanks, Mani > > Konrad >