linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: Add wakeup delay for adau codec
@ 2021-05-13 12:24 Srinivasa Rao Mandadapu
  2021-05-17 22:44 ` Stephen Boyd
  0 siblings, 1 reply; 3+ messages in thread
From: Srinivasa Rao Mandadapu @ 2021-05-13 12:24 UTC (permalink / raw)
  To: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree,
	linux-kernel, rohitkr, srinivas.kandagatla, dianders, swboyd,
	judyhsiao
  Cc: Srinivasa Rao Mandadapu

Add wakeup delay for fixing PoP noise during capture begin.

Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
index 4c6e433c8226..3eb8550da1fc 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
@@ -23,6 +23,7 @@ / {
 	adau7002: audio-codec-1 {
 		compatible = "adi,adau7002";
 		IOVDD-supply = <&pp1800_l15a>;
+		wakeup-delay-ms = <15>;
 		#sound-dai-cells = <0>;
 	};
 };
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: Add wakeup delay for adau codec
  2021-05-13 12:24 [PATCH] arm64: dts: qcom: Add wakeup delay for adau codec Srinivasa Rao Mandadapu
@ 2021-05-17 22:44 ` Stephen Boyd
  2021-05-20 21:40   ` Doug Anderson
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2021-05-17 22:44 UTC (permalink / raw)
  To: Srinivasa Rao Mandadapu, agross, bjorn.andersson, devicetree,
	dianders, judyhsiao, linux-arm-msm, linux-kernel, robh+dt,
	rohitkr, srinivas.kandagatla

Quoting Srinivasa Rao Mandadapu (2021-05-13 05:24:29)
> Add wakeup delay for fixing PoP noise during capture begin.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> index 4c6e433c8226..3eb8550da1fc 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> @@ -23,6 +23,7 @@ / {
>         adau7002: audio-codec-1 {
>                 compatible = "adi,adau7002";
>                 IOVDD-supply = <&pp1800_l15a>;
> +               wakeup-delay-ms = <15>;

Is this part of the binding?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: Add wakeup delay for adau codec
  2021-05-17 22:44 ` Stephen Boyd
@ 2021-05-20 21:40   ` Doug Anderson
  0 siblings, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2021-05-20 21:40 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Srinivasa Rao Mandadapu, Andy Gross, Bjorn Andersson,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Judy Hsiao, linux-arm-msm, LKML, Rob Herring, Rohit kumar,
	Srinivas Kandagatla

Hi,


On Mon, May 17, 2021 at 3:44 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Srinivasa Rao Mandadapu (2021-05-13 05:24:29)
> > Add wakeup delay for fixing PoP noise during capture begin.
> >
> > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > index 4c6e433c8226..3eb8550da1fc 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > @@ -23,6 +23,7 @@ / {
> >         adau7002: audio-codec-1 {
> >                 compatible = "adi,adau7002";
> >                 IOVDD-supply = <&pp1800_l15a>;
> > +               wakeup-delay-ms = <15>;
>
> Is this part of the binding?

It doesn't seem to be, but it's supported by the code. It's also in
the generic "dmic" bindings. The bindings are pre-yaml. Seems like
someone needs to take charge and clean those up, but I'm not sure we
need to block this patch on it?

Though I'm not an expert on audio stuff, assuming that this works OK
I'm fine with:

Reviewed-by: Douglas Anderson <dianders@chromium.org>

-Doug

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-20 21:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 12:24 [PATCH] arm64: dts: qcom: Add wakeup delay for adau codec Srinivasa Rao Mandadapu
2021-05-17 22:44 ` Stephen Boyd
2021-05-20 21:40   ` Doug Anderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).