linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] bus: qcom: Add missing clk_disable_unprepare() on error path
@ 2021-05-17 11:09 Yang Yingliang
  0 siblings, 0 replies; only message in thread
From: Yang Yingliang @ 2021-05-17 11:09 UTC (permalink / raw)
  To: linux-kernel, linux-arm-msm; +Cc: bjorn.andersson

After calling clk_prepare_enable(), clk_disable_unprepare() need
be called when read csindex failed.

Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/bus/qcom-ebi2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
index 0b8f53a688b8..3cffac13bc5f 100644
--- a/drivers/bus/qcom-ebi2.c
+++ b/drivers/bus/qcom-ebi2.c
@@ -355,7 +355,7 @@ static int qcom_ebi2_probe(struct platform_device *pdev)
 		ret = of_property_read_u32(child, "reg", &csindex);
 		if (ret) {
 			of_node_put(child);
-			return ret;
+			goto err_disable_clk;
 		}
 
 		if (csindex > 5) {
-- 
2.25.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-17 11:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 11:09 [PATCH -next] bus: qcom: Add missing clk_disable_unprepare() on error path Yang Yingliang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).