linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: ipq8074: fix PCI-E clock oops
@ 2021-05-18 17:51 Robert Marko
  2021-06-28  0:07 ` Stephen Boyd
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Marko @ 2021-05-18 17:51 UTC (permalink / raw)
  To: agross, bjorn.andersson, mturquette, sboyd, speriaka, sivaprak,
	linux-arm-msm, linux-clk, linux-kernel
  Cc: Robert Marko

Fix PCI-E clock related kernel oops that are causes by missing
parent_names.

Without the use of parent_names kernel will panic on
clk_core_get_parent_by_index() due to a NULL pointer.

Without this earlycon is needed to even catch the OOPS as it will reset
the board before serial is initialized.

Fixes: f0cfcf1ade20 ("clk: qcom: ipq8074: Add missing clocks for pcie")
Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 drivers/clk/qcom/gcc-ipq8074.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
index 0c619ed35c82..8d8b1717a203 100644
--- a/drivers/clk/qcom/gcc-ipq8074.c
+++ b/drivers/clk/qcom/gcc-ipq8074.c
@@ -4357,8 +4357,7 @@ static struct clk_rcg2 pcie0_rchng_clk_src = {
 	.parent_map = gcc_xo_gpll0_map,
 	.clkr.hw.init = &(struct clk_init_data){
 		.name = "pcie0_rchng_clk_src",
-		.parent_hws = (const struct clk_hw *[]) {
-				&gpll0.clkr.hw },
+		.parent_names = gcc_xo_gpll0,
 		.num_parents = 2,
 		.ops = &clk_rcg2_ops,
 	},
@@ -4372,8 +4371,8 @@ static struct clk_branch gcc_pcie0_rchng_clk = {
 		.enable_mask = BIT(1),
 		.hw.init = &(struct clk_init_data){
 			.name = "gcc_pcie0_rchng_clk",
-			.parent_hws = (const struct clk_hw *[]){
-				&pcie0_rchng_clk_src.clkr.hw,
+			.parent_names = (const char *[]){
+				"pcie0_rchng_clk_src",
 			},
 			.num_parents = 1,
 			.flags = CLK_SET_RATE_PARENT,
@@ -4390,8 +4389,8 @@ static struct clk_branch gcc_pcie0_axi_s_bridge_clk = {
 		.enable_mask = BIT(0),
 		.hw.init = &(struct clk_init_data){
 			.name = "gcc_pcie0_axi_s_bridge_clk",
-			.parent_hws = (const struct clk_hw *[]){
-				&pcie0_axi_clk_src.clkr.hw,
+			.parent_names = (const char *[]){
+				"pcie0_axi_clk_src"
 			},
 			.num_parents = 1,
 			.flags = CLK_SET_RATE_PARENT,
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: ipq8074: fix PCI-E clock oops
  2021-05-18 17:51 [PATCH] clk: qcom: ipq8074: fix PCI-E clock oops Robert Marko
@ 2021-06-28  0:07 ` Stephen Boyd
  2021-09-08 14:28   ` Robert Marko
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2021-06-28  0:07 UTC (permalink / raw)
  To: Robert Marko, agross, bjorn.andersson, linux-arm-msm, linux-clk,
	linux-kernel, mturquette, sivaprak, speriaka
  Cc: Robert Marko

Quoting Robert Marko (2021-05-18 10:51:53)
> Fix PCI-E clock related kernel oops that are causes by missing
> parent_names.
> 
> Without the use of parent_names kernel will panic on
> clk_core_get_parent_by_index() due to a NULL pointer.
> 
> Without this earlycon is needed to even catch the OOPS as it will reset
> the board before serial is initialized.

Can you share the oops message here in the commit text?

> 
> Fixes: f0cfcf1ade20 ("clk: qcom: ipq8074: Add missing clocks for pcie")
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
>  drivers/clk/qcom/gcc-ipq8074.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> index 0c619ed35c82..8d8b1717a203 100644
> --- a/drivers/clk/qcom/gcc-ipq8074.c
> +++ b/drivers/clk/qcom/gcc-ipq8074.c
> @@ -4357,8 +4357,7 @@ static struct clk_rcg2 pcie0_rchng_clk_src = {
>         .parent_map = gcc_xo_gpll0_map,
>         .clkr.hw.init = &(struct clk_init_data){
>                 .name = "pcie0_rchng_clk_src",
> -               .parent_hws = (const struct clk_hw *[]) {
> -                               &gpll0.clkr.hw },
> +               .parent_names = gcc_xo_gpll0,

This seems to imply that we need to have two parents but we didn't
realize that was the case. Ouch! Please use a struct clk_parent_data
array and then use the firmware name for XO and the clk_hw pointer for
gpll0.

>                 .num_parents = 2,
>                 .ops = &clk_rcg2_ops,
>         },
> @@ -4372,8 +4371,8 @@ static struct clk_branch gcc_pcie0_rchng_clk = {
>                 .enable_mask = BIT(1),
>                 .hw.init = &(struct clk_init_data){
>                         .name = "gcc_pcie0_rchng_clk",
> -                       .parent_hws = (const struct clk_hw *[]){
> -                               &pcie0_rchng_clk_src.clkr.hw,
> +                       .parent_names = (const char *[]){
> +                               "pcie0_rchng_clk_src",
>                         },
>                         .num_parents = 1,
>                         .flags = CLK_SET_RATE_PARENT,
> @@ -4390,8 +4389,8 @@ static struct clk_branch gcc_pcie0_axi_s_bridge_clk = {
>                 .enable_mask = BIT(0),
>                 .hw.init = &(struct clk_init_data){
>                         .name = "gcc_pcie0_axi_s_bridge_clk",
> -                       .parent_hws = (const struct clk_hw *[]){
> -                               &pcie0_axi_clk_src.clkr.hw,
> +                       .parent_names = (const char *[]){
> +                               "pcie0_axi_clk_src"

These two hunks can be dropped.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: ipq8074: fix PCI-E clock oops
  2021-06-28  0:07 ` Stephen Boyd
@ 2021-09-08 14:28   ` Robert Marko
  0 siblings, 0 replies; 3+ messages in thread
From: Robert Marko @ 2021-09-08 14:28 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: agross, Bjorn Andersson, linux-arm-msm, linux-clk, open list,
	Michael Turquette, sivaprak, speriaka

On Mon, 28 Jun 2021 at 02:07, Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Robert Marko (2021-05-18 10:51:53)
> > Fix PCI-E clock related kernel oops that are causes by missing
> > parent_names.
> >
> > Without the use of parent_names kernel will panic on
> > clk_core_get_parent_by_index() due to a NULL pointer.
> >
> > Without this earlycon is needed to even catch the OOPS as it will reset
> > the board before serial is initialized.
>
> Can you share the oops message here in the commit text?
>
> >
> > Fixes: f0cfcf1ade20 ("clk: qcom: ipq8074: Add missing clocks for pcie")
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > ---
> >  drivers/clk/qcom/gcc-ipq8074.c | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> > index 0c619ed35c82..8d8b1717a203 100644
> > --- a/drivers/clk/qcom/gcc-ipq8074.c
> > +++ b/drivers/clk/qcom/gcc-ipq8074.c
> > @@ -4357,8 +4357,7 @@ static struct clk_rcg2 pcie0_rchng_clk_src = {
> >         .parent_map = gcc_xo_gpll0_map,
> >         .clkr.hw.init = &(struct clk_init_data){
> >                 .name = "pcie0_rchng_clk_src",
> > -               .parent_hws = (const struct clk_hw *[]) {
> > -                               &gpll0.clkr.hw },
> > +               .parent_names = gcc_xo_gpll0,
>
> This seems to imply that we need to have two parents but we didn't
> realize that was the case. Ouch! Please use a struct clk_parent_data
> array and then use the firmware name for XO and the clk_hw pointer for
> gpll0.
>
> >                 .num_parents = 2,
> >                 .ops = &clk_rcg2_ops,
> >         },
> > @@ -4372,8 +4371,8 @@ static struct clk_branch gcc_pcie0_rchng_clk = {
> >                 .enable_mask = BIT(1),
> >                 .hw.init = &(struct clk_init_data){
> >                         .name = "gcc_pcie0_rchng_clk",
> > -                       .parent_hws = (const struct clk_hw *[]){
> > -                               &pcie0_rchng_clk_src.clkr.hw,
> > +                       .parent_names = (const char *[]){
> > +                               "pcie0_rchng_clk_src",
> >                         },
> >                         .num_parents = 1,
> >                         .flags = CLK_SET_RATE_PARENT,
> > @@ -4390,8 +4389,8 @@ static struct clk_branch gcc_pcie0_axi_s_bridge_clk = {
> >                 .enable_mask = BIT(0),
> >                 .hw.init = &(struct clk_init_data){
> >                         .name = "gcc_pcie0_axi_s_bridge_clk",
> > -                       .parent_hws = (const struct clk_hw *[]){
> > -                               &pcie0_axi_clk_src.clkr.hw,
> > +                       .parent_names = (const char *[]){
> > +                               "pcie0_axi_clk_src"
>
> These two hunks can be dropped.

Hi Stephen, sorry for the really late reply.
Essentially it looks this is not necessary in the newer kernels,
I tested again with 5.14 and newer and I don't have a panic anymore.
I was hitting the issue with 5.10 kernel.

Regards,
Robert

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-08 14:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 17:51 [PATCH] clk: qcom: ipq8074: fix PCI-E clock oops Robert Marko
2021-06-28  0:07 ` Stephen Boyd
2021-09-08 14:28   ` Robert Marko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).