From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D3EC433B4 for ; Wed, 19 May 2021 14:51:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F54861028 for ; Wed, 19 May 2021 14:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354798AbhESOxM (ORCPT ); Wed, 19 May 2021 10:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244049AbhESOxM (ORCPT ); Wed, 19 May 2021 10:53:12 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A811EC06175F for ; Wed, 19 May 2021 07:51:52 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id g7-20020a9d12870000b0290328b1342b73so4145190otg.9 for ; Wed, 19 May 2021 07:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FTJFgBVyDmUOEWvTRev7q14+qgObUW0H7ne5i0Gbe6Y=; b=S9tVdEtrJGHa2o7lEkJCl4ciWBJIW+7y7XAxPg2JtJRWL8oEtOofCj7Kd+s7C/rIBr X/N8xkmpWtnyWt1DKO7+61sttUWb96XaXea/B1XI7p/WQnRVkFodqInkdzVDOGszpRe4 bpJLlyQD9AEUc4m7DCFI/fKCMPXeM+YTcp1d73LC5Eq2i6Zs/OdFoDQ388kT3FuKiZDB dsyJ9WRYzho23HSpVRA74CioM2IFz/p6ya/SE2EPNaHHGbHjx6SKcHx+OuMx087PBb3/ MqM61FpRqZKf8ve9BqJGm1gC0KM3eQ3qrqTWLKksOYf2pqrZGeeweNHmboD1YyD6ExZR Wt4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FTJFgBVyDmUOEWvTRev7q14+qgObUW0H7ne5i0Gbe6Y=; b=JNbUQRL+XJFYQayXPoJ52zzcV0HWa+WBPX9UoWz816B+uNFVII/jGayBvTnFMQR8cG hTvg34T4NptAtbi2UAdvNZHN+4ib+hTZ6p+9RYUf/uStQpwWMcQnrrnnF4CA1QyxsqxC NmQAE4VbIy4ZjeHq0UuLEWgd6nkSTaSzN4nz5B/EID4VfZWbnJz+sKIMSFV6sHLqYm03 iEkCF1CL1o+Zt5P3ue0EO51UF7iJ9RhlW9Fb2XFVn44jiu+i6VCYzNjpnc4R2uBqILPf 65jwlsAkxIjH+Kp7+ijPzO9hYMo5NN2gKFD1gGzw8yoPrsCiCPF00FPwwK+bqDLu9Ii6 jS6g== X-Gm-Message-State: AOAM532/yoW1TQvoU7Dm7fAxvH/7mwFxZcE08vxbPb8NBh5lSGyEytJN 1NTMutUqxGBHqAvN7mcYtXJw3w== X-Google-Smtp-Source: ABdhPJzY4rU2tPVJy8SezcMhmTeANCYark26o2ccH2Eo3RpalK98eq0y6YRbfDXggAfXeWgxMe1aUg== X-Received: by 2002:a05:6830:1594:: with SMTP id i20mr9168662otr.279.1621435911905; Wed, 19 May 2021 07:51:51 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 67sm4571702otp.68.2021.05.19.07.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 07:51:51 -0700 (PDT) Date: Wed, 19 May 2021 09:51:49 -0500 From: Bjorn Andersson To: abhinavk@codeaurora.org Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Stephen Boyd , sbillaka@codeaurora.org, Tanmay Shah , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dmitry Baryshkov , freedreno@lists.freedesktop.org, Chandan Uddaraju Subject: Re: [Freedreno] [PATCH 0/4] drm/msm/dp: Add support for SC8180x eDP controller Message-ID: <20210519145149.GX2484@yoga> References: <20210511042043.592802-1-bjorn.andersson@linaro.org> <40f6aefd3fa341e2bec2060106389be7@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40f6aefd3fa341e2bec2060106389be7@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 18 May 22:41 CDT 2021, abhinavk@codeaurora.org wrote: > Hi Bjorn > > I had a quick glance on the series and before getting to other things wanted > to know how you are initializing two different connectors for > DP & EDP resp. > > The connector type for DP should be DRM_MODE_CONNECTOR_DisplayPort and eDP > should be DRM_MODE_CONNECTOR_eDP. As far as I've been able to conclude there is no eDP support in the upstream DPU driver; an encoder of type DRM_MODE_ENCODER_TMDS will only attach to INTF_DP. > We need both to be created so that both EDP and DP can be supported > concurrently. > Further more the DP controller driver has a global variable to track state and the INTF-picker will always pick the interface of index 0 when setting up the DP controller. > Will these changes work for concurrent eDP and DP case? > The proposed changes are all that I need to get eDP working on my sc8180x laptop. But the DPU code does not currently support more than a single DP interface - and that has to be on the first INTF_DP that the DPU driver knows about. But this is a limitation we should fix, rather than claiming that you can only have one of each. Further more, afaict the sc7280 DP controller can do both DP and eDP, so it would make sense not to distinguish the interfaces as eDP or DP - just because the product in mind will use eDP. PS. I've currently disabled the eDP interface on my laptop and am working on trying to get Type-C DP working. Once that's in place I'd need a better INTF/encoder picker - because the current model of just picking INTF_DP 0 (or in a sequential fashion) won't work. Regards, Bjorn > Thanks > > Abhinav > > On 2021-05-10 21:20, Bjorn Andersson wrote: > > The first patch in the series is somewhat unrelated to the support, but > > simplifies reasoning and debugging of timing related issues. > > > > The second patch introduces support for dealing with different register > > block > > layouts, which is used in the forth patch to describe the hardware > > blocks found > > in the SC8180x eDP block. > > > > The third patch configures the INTF_CONFIG register, which carries the > > configuration for widebus handling. As with the DPU the bootloader > > enables > > widebus and we need to disable it, or implement support for adjusting > > the > > timing. > > > > Bjorn Andersson (4): > > drm/msm/dp: Simplify the mvid/nvid calculation > > drm/msm/dp: Store each subblock in the io region > > drm/msm/dp: Initialize the INTF_CONFIG register > > drm/msm/dp: Add support for SC8180x eDP > > > > drivers/gpu/drm/msm/dp/dp_catalog.c | 99 +++++++---------------------- > > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > > drivers/gpu/drm/msm/dp/dp_parser.c | 22 +++++++ > > drivers/gpu/drm/msm/dp/dp_parser.h | 8 +++ > > 4 files changed, 53 insertions(+), 77 deletions(-)