From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Rob Clark <robdclark@chromium.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org (open list)
Subject: [RFC 2/3] drm/atomic: Call dma_fence_boost() when we've missed a vblank
Date: Wed, 19 May 2021 11:38:53 -0700 [thread overview]
Message-ID: <20210519183855.1523927-3-robdclark@gmail.com> (raw)
In-Reply-To: <20210519183855.1523927-1-robdclark@gmail.com>
From: Rob Clark <robdclark@chromium.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/drm_atomic_helper.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 560aaecba31b..fe10fc2e7f86 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -1435,11 +1435,15 @@ int drm_atomic_helper_wait_for_fences(struct drm_device *dev,
int i, ret;
for_each_new_plane_in_state(state, plane, new_plane_state, i) {
+ u64 vblank_count;
+
if (!new_plane_state->fence)
continue;
WARN_ON(!new_plane_state->fb);
+ vblank_count = drm_crtc_vblank_count(new_plane_state->crtc);
+
/*
* If waiting for fences pre-swap (ie: nonblock), userspace can
* still interrupt the operation. Instead of blocking until the
@@ -1449,6 +1453,13 @@ int drm_atomic_helper_wait_for_fences(struct drm_device *dev,
if (ret)
return ret;
+ /*
+ * Check if we've missed a vblank while waiting, and if we have
+ * signal the fence that it's signaler should be boosted
+ */
+ if (vblank_count != drm_crtc_vblank_count(new_plane_state->crtc))
+ dma_fence_boost(new_plane_state->fence);
+
dma_fence_put(new_plane_state->fence);
new_plane_state->fence = NULL;
}
--
2.30.2
next prev parent reply other threads:[~2021-05-19 18:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 18:38 [RFC 0/3] dma-fence: Add a "boost" mechanism Rob Clark
2021-05-19 18:38 ` [RFC 1/3] dma-fence: Add boost fence op Rob Clark
2021-05-20 6:46 ` Christian König
2021-05-20 14:07 ` Rob Clark
2021-05-20 14:11 ` Christian König
2021-05-20 14:54 ` Rob Clark
2021-05-20 16:01 ` [Linaro-mm-sig] " Christian König
2021-05-20 16:34 ` Daniel Vetter
2021-05-20 16:40 ` Christian König
2021-05-20 17:08 ` Daniel Vetter
2021-05-21 7:43 ` Christian König
2021-05-21 14:21 ` Daniel Vetter
2021-05-20 16:25 ` Daniel Vetter
2021-05-19 18:38 ` Rob Clark [this message]
2021-05-20 16:29 ` [RFC 2/3] drm/atomic: Call dma_fence_boost() when we've missed a vblank Daniel Vetter
2021-05-30 14:33 ` Rob Clark
2021-06-01 14:18 ` Daniel Vetter
2021-06-01 15:46 ` Rob Clark
2021-06-01 16:11 ` Daniel Vetter
2021-05-19 18:38 ` [RFC 3/3] drm/msm: Wire up gpu boost Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519183855.1523927-3-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robdclark@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).