From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Krishna Manikandan <mkrishn@codeaurora.org>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kalyan_t@codeaurora.org,
tanmay@codeaurora.org, abhinavk@codeaurora.org,
robdclark@gmail.com, swboyd@chromium.org, vinod.koul@linaro.org,
dianders@chromium.org, khsieh@codeaurora.org, robh+dt@kernel.org,
sean@poorly.run, robh@kernel.org
Subject: Re: [PATCH v17 3/4] dt-bindings: msm: dsi: add yaml schemas for DSI PHY bindings
Date: Fri, 21 May 2021 12:18:16 -0500 [thread overview]
Message-ID: <20210521171816.GD2484@yoga> (raw)
In-Reply-To: <1621592844-6414-3-git-send-email-mkrishn@codeaurora.org>
On Fri 21 May 05:27 CDT 2021, Krishna Manikandan wrote:
> Add YAML schema for the device tree bindings for DSI PHY.
>
> Signed-off-by: Krishna Manikandan <mkrishn@codeaurora.org>
>
> Changes in v1:
> - Merge dsi-phy.yaml and dsi-phy-10nm.yaml (Stephen Boyd)
> - Remove qcom,dsi-phy-regulator-ldo-mode (Stephen Boyd)
> - Add clock cells properly (Stephen Boyd)
> - Remove unnecessary decription from clock names (Stephen Boyd)
> - Add pin names for the supply entries for 10nm phy which is
> used in sc7180 and sdm845 (Stephen Boyd)
> - Remove unused header files from examples (Stephen Boyd)
> - Drop labels for display nodes and correct node name (Stephen Boyd)
>
> Changes in v2:
> - Drop maxItems for clock (Stephen Boyd)
> - Add vdds supply pin information for sdm845 (Stephen Boyd)
> - Add examples for 14nm, 20nm and 28nm phy yaml files (Stephen Boyd)
> - Keep child nodes directly under soc node (Stephen Boyd)
>
> Changes in v3:
> - Use a separate yaml file to describe the common properties
> for all the dsi phy versions (Stephen Boyd)
> - Remove soc from examples (Stephen Boyd)
> - Add description for register property
>
> Changes in v4:
> - Modify the title for all the phy versions (Stephen Boyd)
> - Drop description for all the phy versions (Stephen Boyd)
> - Modify the description for register property (Stephen Boyd)
>
> Changes in v5:
> - Remove unused properties from common dsi phy file
> - Add clock-cells and phy-cells to required property
> list (Stephen Boyd)
>
> Changes in v6:
> - Add proper compatible string in example
> ---
> .../bindings/display/msm/dsi-phy-10nm.yaml | 68 +++++++++++++++++++++
> .../bindings/display/msm/dsi-phy-14nm.yaml | 66 ++++++++++++++++++++
> .../bindings/display/msm/dsi-phy-20nm.yaml | 71 ++++++++++++++++++++++
> .../bindings/display/msm/dsi-phy-28nm.yaml | 68 +++++++++++++++++++++
> .../bindings/display/msm/dsi-phy-common.yaml | 40 ++++++++++++
> 5 files changed, 313 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml
> create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml
> create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-20nm.yaml
> create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-common.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml
> new file mode 100644
> index 0000000..4a26bef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/msm/dsi-phy-10nm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Display DSI 10nm PHY
> +
> +maintainers:
> + - Krishna Manikandan <mkrishn@codeaurora.org>
> +
> +allOf:
> + - $ref: dsi-phy-common.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: qcom,dsi-phy-10nm
> + - const: qcom,dsi-phy-10nm-8998
> +
> + reg:
> + items:
> + - description: dsi phy register set
> + - description: dsi phy lane register set
> + - description: dsi pll register set
> +
> + reg-names:
> + items:
> + - const: dsi_phy
> + - const: dsi_phy_lane
> + - const: dsi_pll
> +
> + vdds-supply:
> + description: |
> + Connected to DSI0_MIPI_DSI_PLL_VDDA0P9 pin for sc7180 target and
> + connected to VDDA_MIPI_DSI_0_PLL_0P9 pin for sdm845 target
"Reference to the 0.9V supply for the PLL." would have been sufficient.
But overall I think the patch looks good.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
next prev parent reply other threads:[~2021-05-21 17:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 10:27 [PATCH v17 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings Krishna Manikandan
2021-05-21 10:27 ` [PATCH v17 2/4] dt-bindings: msm: dsi: add yaml schemas for DSI bindings Krishna Manikandan
2021-05-21 17:14 ` Bjorn Andersson
2021-05-21 18:37 ` Rob Herring
2021-05-21 20:47 ` Stephen Boyd
2021-05-21 10:27 ` [PATCH v17 3/4] dt-bindings: msm: dsi: add yaml schemas for DSI PHY bindings Krishna Manikandan
2021-05-21 17:18 ` Bjorn Andersson [this message]
2021-05-21 18:29 ` Rob Herring
2021-05-21 20:47 ` Stephen Boyd
2021-05-21 10:27 ` [PATCH v17 4/4] dt-bindings: msm/dp: Add bindings of MSM DisplayPort controller Krishna Manikandan
2021-05-21 17:19 ` Bjorn Andersson
2021-05-21 18:37 ` Rob Herring
2021-05-21 20:46 ` Stephen Boyd
2021-05-21 16:00 ` [PATCH v17 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings Bjorn Andersson
2021-05-21 17:11 ` Bjorn Andersson
2021-05-21 20:51 ` Stephen Boyd
2021-05-21 21:29 ` Bjorn Andersson
2021-05-21 18:29 ` Rob Herring
2021-05-21 20:47 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521171816.GD2484@yoga \
--to=bjorn.andersson@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kalyan_t@codeaurora.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrishn@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=tanmay@codeaurora.org \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).