linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jack Pham <jackp@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Wesley Cheng <wcheng@codeaurora.org>,
	balbi@kernel.org, gregkh@linuxfoundation.org, agross@kernel.org,
	robh+dt@kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, Thinh.Nguyen@synopsys.com
Subject: Re: [PATCH v8 5/5] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic
Date: Sat, 29 May 2021 12:24:21 -0700	[thread overview]
Message-ID: <20210529192420.GA11263@jackp-linux.qualcomm.com> (raw)
In-Reply-To: <YLJ000lIVhZM5WEV@builder.lan>

Hi Bjorn,

On Sat, May 29, 2021 at 12:07:31PM -0500, Bjorn Andersson wrote:
> On Wed 19 May 02:43 CDT 2021, Wesley Cheng wrote:
> 
> > Enable the flexible TX FIFO resize logic on SM8150.  Using a larger TX FIFO
> > SZ can help account for situations when system latency is greater than the
> > USB bus transmission latency.
> > 
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> 
> Based on my previous request of always adding this for the Qualcomm
> platforms that supports it, which is implemented in patch 4, I don't see
> a need for this patch.
> 
> Am I missing something?

Looks like Wesley had quickly sent a V9 of the series right after V8,
and the DTSI change is dropped.

https://lore.kernel.org/linux-usb/1621410561-32762-1-git-send-email-wcheng@codeaurora.org/T/#t

Thanks,
Jack

> > ---
> >  arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > index 51235a9..8f532cb 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > @@ -2275,6 +2275,7 @@
> >  				iommus = <&apps_smmu 0x140 0>;
> >  				snps,dis_u2_susphy_quirk;
> >  				snps,dis_enblslpm_quirk;
> > +				tx-fifo-resize;
> >  				phys = <&usb_1_hsphy>, <&usb_1_ssphy>;
> >  				phy-names = "usb2-phy", "usb3-phy";
> >  			};

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2021-05-29 19:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19  7:43 [PATCH v8 0/5] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2021-05-19  7:43 ` [PATCH v8 1/5] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng
2021-05-19  7:43 ` [PATCH v8 2/5] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng
2021-05-19  7:43 ` [PATCH v8 3/5] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2021-05-19  7:43 ` [PATCH v8 4/5] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default Wesley Cheng
2021-05-19  7:43 ` [PATCH v8 5/5] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic Wesley Cheng
2021-05-29 17:07   ` Bjorn Andersson
2021-05-29 19:24     ` Jack Pham [this message]
2021-05-29  0:40 ` [PATCH v8 0/5] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210529192420.GA11263@jackp-linux.qualcomm.com \
    --to=jackp@codeaurora.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=agross@kernel.org \
    --cc=balbi@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wcheng@codeaurora.org \
    --subject='Re: [PATCH v8 5/5] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).