[PATCH v4 0/6] iommu/arm-smmu: adreno-smmu page fault handling

From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: "Jordan Crouse" <jordan@cosmicpenguin.net>,
	"Rob Clark" <robdclark@chromium.org>,
	"Abhinav Kumar" <abhinavk@codeaurora.org>,
	"Akhil P Oommen" <akhilpo@codeaurora.org>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@somainline.org>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Dave Airlie" <airlied@redhat.com>,
	"Douglas Anderson" <dianders@chromium.org>,
	"Eric Anholt" <eric@anholt.net>,
	freedreno@lists.freedesktop.org (open list:DRM DRIVER FOR MSM
	ADRENO GPU),
	iommu@lists.linux-foundation.org (open list:IOMMU DRIVERS),
	"Iskren Chernev" <iskren.chernev@gmail.com>,
	"Joerg Roedel" <jroedel@suse.de>,
	"Jonathan Marek" <jonathan@marek.ca>,
	"Kalyan Thota" <kalyan_t@codeaurora.org>,
	"Konrad Dybcio" <konrad.dybcio@somainline.org>,
	"Krishna Reddy" <vdumpa@nvidia.com>,
	"Kristian H. Kristensen" <hoegsberg@google.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org (moderated list:ARM SMMU
	DRIVERS),
	linux-arm-msm@vger.kernel.org (open list:DRM DRIVER FOR MSM
	ADRENO GPU), linux-kernel@vger.kernel.org (open list),
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Maxime Ripard" <maxime@cerno.tech>,
	"Qinglang Miao" <miaoqinglang@huawei.com>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Sai Prakash Ranjan" <saiprakash.ranjan@codeaurora.org>,
	"Sharat Masetty" <smasetty@codeaurora.org>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Will Deacon" <will@kernel.org>,
	"Zhenzhong Duan" <zhenzhong.duan@gmail.com>
Subject: [PATCH v4 0/6] iommu/arm-smmu: adreno-smmu page fault handling
Date: Tue,  1 Jun 2021 15:47:18 -0700	[thread overview]
Message-ID: <20210601224750.513996-1-robdclark@gmail.com> (raw)

From: Rob Clark <robdclark@chromium.org>

This picks up an earlier series[1] from Jordan, and adds additional
support needed to generate GPU devcore dumps on iova faults.  Original
description:

This is a stack to add an Adreno GPU specific handler for pagefaults. The first
patch starts by wiring up report_iommu_fault for arm-smmu. The next patch adds
a adreno-smmu-priv function hook to capture a handful of important debugging
registers such as TTBR0, CONTEXTIDR, FSYNR0 and others. This is used by the
third patch to print more detailed information on page fault such as the TTBR0
for the pagetable that caused the fault and the source of the fault as
determined by a combination of the FSYNR1 register and an internal GPU
register.

This code provides a solid base that we can expand on later for even more
extensive GPU side page fault debugging capabilities.

v4: [Rob] Add support to stall SMMU on fault, and let the GPU driver
    resume translation after it has had a chance to snapshot the GPUs
    state
v3: Always clear FSR even if the target driver is going to handle resume
v2: Fix comment wording and function pointer check per Rob Clark

[1] https://lore.kernel.org/dri-devel/20210225175135.91922-1-jcrouse@codeaurora.org/

Jordan Crouse (3):
  iommu/arm-smmu: Add support for driver IOMMU fault handlers
  iommu/arm-smmu-qcom: Add an adreno-smmu-priv callback to get pagefault
    info
  drm/msm: Improve the a6xx page fault handler

Rob Clark (3):
  iommu/arm-smmu-qcom: Add stall support
  drm/msm: Add crashdump support for stalled SMMU
  drm/msm: devcoredump iommu fault support

 drivers/gpu/drm/msm/adreno/a2xx_gpu.c       |   2 +-
 drivers/gpu/drm/msm/adreno/a3xx_gpu.c       |   2 +-
 drivers/gpu/drm/msm/adreno/a4xx_gpu.c       |   2 +-
 drivers/gpu/drm/msm/adreno/a5xx_gpu.c       |   9 +-
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c       | 101 +++++++++++++++++++-
 drivers/gpu/drm/msm/adreno/a6xx_gpu.h       |   2 +-
 drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c |  43 +++++++--
 drivers/gpu/drm/msm/adreno/adreno_gpu.c     |  15 +++
 drivers/gpu/drm/msm/msm_debugfs.c           |   2 +-
 drivers/gpu/drm/msm/msm_gem.h               |   1 +
 drivers/gpu/drm/msm/msm_gem_submit.c        |   1 +
 drivers/gpu/drm/msm/msm_gpu.c               |  55 ++++++++++-
 drivers/gpu/drm/msm/msm_gpu.h               |  19 +++-
 drivers/gpu/drm/msm/msm_gpummu.c            |   5 +
 drivers/gpu/drm/msm/msm_iommu.c             |  22 ++++-
 drivers/gpu/drm/msm/msm_mmu.h               |   5 +-
 drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c  |  50 ++++++++++
 drivers/iommu/arm/arm-smmu/arm-smmu.c       |   9 +-
 drivers/iommu/arm/arm-smmu/arm-smmu.h       |   2 +
 include/linux/adreno-smmu-priv.h            |  38 +++++++-
 20 files changed, 354 insertions(+), 31 deletions(-)

-- 
2.31.1