From: Mark Rutland <mark.rutland@arm.com>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: will@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] perf: qcom_l2_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
Date: Wed, 2 Jun 2021 11:16:00 +0100 [thread overview]
Message-ID: <20210602101600.GB12753@C02TD0UTHF1T.local> (raw)
In-Reply-To: <1622595642-61678-3-git-send-email-tiantao6@hisilicon.com>
On Wed, Jun 02, 2021 at 09:00:42AM +0800, Tian Tao wrote:
> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN); request_irq(dev, irq...); can
> be replaced by request_irq() with IRQF_NO_AUTOEN flag.
>
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
As with patch 1, I see that the patch above was merged in v5.13-rc1 as commit:
cbe16f35bee6880b ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
With that in mind:
Acked-by: Mark Rutland <mark.rutland@arm.com>
I expect Will will pick this up.
Thanks,
Mark.
> ---
> drivers/perf/qcom_l2_pmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c
> index fc54a80..b60e301 100644
> --- a/drivers/perf/qcom_l2_pmu.c
> +++ b/drivers/perf/qcom_l2_pmu.c
> @@ -869,14 +869,14 @@ static int l2_cache_pmu_probe_cluster(struct device *dev, void *data)
> irq = platform_get_irq(sdev, 0);
> if (irq < 0)
> return irq;
> - irq_set_status_flags(irq, IRQ_NOAUTOEN);
> cluster->irq = irq;
>
> cluster->l2cache_pmu = l2cache_pmu;
> cluster->on_cpu = -1;
>
> err = devm_request_irq(&pdev->dev, irq, l2_cache_handle_irq,
> - IRQF_NOBALANCING | IRQF_NO_THREAD,
> + IRQF_NOBALANCING | IRQF_NO_THREAD |
> + IRQF_NO_AUTOEN,
> "l2-cache-pmu", cluster);
> if (err) {
> dev_err(&pdev->dev,
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-06-02 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 1:00 [PATCH 0/2] move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-06-02 1:00 ` [PATCH 1/2] arm_pmu: " Tian Tao
2021-06-02 10:14 ` Mark Rutland
2021-06-02 1:00 ` [PATCH 2/2] perf: qcom_l2_pmu: " Tian Tao
2021-06-02 10:16 ` Mark Rutland [this message]
2021-06-02 17:06 ` [PATCH 0/2] " Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602101600.GB12753@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).