From: Kees Cook <keescook@chromium.org>
To: Dave Airlie <airlied@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
Arnd Bergmann <arnd@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
kernel test robot <lkp@intel.com>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Emma Anholt <emma@anholt.net>, Rob Clark <robdclark@gmail.com>,
Sean Paul <sean@poorly.run>,
Sharat Masetty <smasetty@codeaurora.org>,
Rob Herring <robh@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org
Subject: [PATCH 1/3] drm: Avoid circular dependencies for CONFIG_FB
Date: Wed, 2 Jun 2021 14:52:50 -0700 [thread overview]
Message-ID: <20210602215252.695994-2-keescook@chromium.org> (raw)
In-Reply-To: <20210602215252.695994-1-keescook@chromium.org>
When cleaning up other drm config dependencies, it is too easy to create
larger problems. Instead, mark CONFIG_FB as a "depends":
drivers/gpu/drm/Kconfig:74:error: recursive dependency detected!
Suggested-by: Arnd Bergmann <arnd@kernel.org>
Link: https://lore.kernel.org/lkml/CAK8P3a3jUQs6c5tESSNMbqfuymewj9FhqRizyHcfOXf8Rgy-nA@mail.gmail.com/
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/gpu/drm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 3c16bd1afd87..90891284ccec 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -83,7 +83,7 @@ config DRM_KMS_HELPER
config DRM_KMS_FB_HELPER
bool
depends on DRM_KMS_HELPER
- select FB
+ depends on FB
select FRAMEBUFFER_CONSOLE if !EXPERT
select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE
select FB_SYS_FOPS
--
2.25.1
next prev parent reply other threads:[~2021-06-02 21:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 21:52 [PATCH 0/3] drm: Fix randconfig link failures Kees Cook
2021-06-02 21:52 ` Kees Cook [this message]
2021-06-03 8:48 ` [PATCH 1/3] drm: Avoid circular dependencies for CONFIG_FB Daniel Vetter
2021-06-03 18:48 ` Rob Herring
2021-06-02 21:52 ` [PATCH 2/3] drm/msm/a6xx: add CONFIG_QCOM_LLCC dependency Kees Cook
2021-06-02 21:52 ` [PATCH 3/3] drm/pl111: depend on CONFIG_VEXPRESS_CONFIG Kees Cook
2021-06-03 18:42 ` Rob Herring
2021-06-03 19:19 ` Daniel Vetter
2021-06-03 21:19 ` Kees Cook
2021-06-03 21:29 ` Kees Cook
2021-06-03 21:41 ` Daniel Vetter
2021-06-03 21:48 ` Kees Cook
2021-06-03 19:54 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602215252.695994-2-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=arnd@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=freedreno@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=smasetty@codeaurora.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).