From: Guru Das Srinagesh <gurus@codeaurora.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
lee.jones@linaro.org, agross@kernel.org
Subject: Re: [PATCH -next] mfd: pm8008: Fix return value check in pm8008_probe()
Date: Thu, 3 Jun 2021 10:12:53 -0700 [thread overview]
Message-ID: <20210603171253.GA25742@codeaurora.org> (raw)
In-Reply-To: <20210603141357.572347-1-yangyingliang@huawei.com>
On Thu, Jun 03, 2021 at 10:13:57PM +0800, Yang Yingliang wrote:
> In case of error, the function devm_regmap_init_i2c() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Guru Das Srinagesh <gurus@codeaurora.org>
> ---
> drivers/mfd/qcom-pm8008.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index c472d7f8103c..dfefa60d693b 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -223,7 +223,7 @@ static int pm8008_probe(struct i2c_client *client)
> struct pm8008_data *chip;
>
> chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
> - if (!chip)
> + if (IS_ERR(chip))
> return -ENOMEM;
>
> chip->dev = &client->dev;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-06-03 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 14:13 [PATCH -next] mfd: pm8008: Fix return value check in pm8008_probe() Yang Yingliang
2021-06-03 17:12 ` Guru Das Srinagesh [this message]
2021-06-03 17:31 ` Dmitry Baryshkov
2021-06-03 19:05 ` Guru Das Srinagesh
2021-06-04 1:26 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603171253.GA25742@codeaurora.org \
--to=gurus@codeaurora.org \
--cc=agross@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).