From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Cc: <lee.jones@linaro.org>, <agross@kernel.org>,
<gurus@codeaurora.org>, <dmitry.baryshkov@linaro.org>
Subject: [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe()
Date: Sat, 5 Jun 2021 10:24:46 +0800 [thread overview]
Message-ID: <20210605022446.4119978-1-yangyingliang@huawei.com> (raw)
In case of error, the function devm_regmap_init_i2c() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
v3:
return PTR_ERR(chip->regmap) instead of ENODEV
---
drivers/mfd/qcom-pm8008.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index c472d7f8103c..fb8915a682ad 100644
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -228,8 +228,8 @@ static int pm8008_probe(struct i2c_client *client)
chip->dev = &client->dev;
chip->regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg);
- if (!chip->regmap)
- return -ENODEV;
+ if (IS_ERR(chip->regmap))
+ return PTR_ERR(chip->regmap);
i2c_set_clientdata(client, chip);
--
2.25.1
next reply other threads:[~2021-06-05 2:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 2:24 Yang Yingliang [this message]
2021-06-06 3:33 ` Bjorn Andersson
2021-06-07 20:30 ` Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210605022446.4119978-1-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=agross@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gurus@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).