linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guru Das Srinagesh <gurus@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Yang Yingliang <yangyingliang@huawei.com>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	lee.jones@linaro.org, agross@kernel.org,
	dmitry.baryshkov@linaro.org
Subject: Re: [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe()
Date: Mon, 7 Jun 2021 13:30:19 -0700	[thread overview]
Message-ID: <20210607203019.GA11347@codeaurora.org> (raw)
In-Reply-To: <YLxCGLALLlO4i14n@builder.lan>

On Sat, Jun 05, 2021 at 10:33:44PM -0500, Bjorn Andersson wrote:
> On Fri 04 Jun 21:24 CDT 2021, Yang Yingliang wrote:
> 
> > In case of error, the function devm_regmap_init_i2c() returns ERR_PTR()
> > and never returns NULL. The NULL test in the return value check
> > should be replaced with IS_ERR().
> > 
> > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Acked-by: Guru Das Srinagesh <gurus@codeaurora.org>

> 
> > ---
> > v3:
> >   return PTR_ERR(chip->regmap) instead of ENODEV
> > ---
> >  drivers/mfd/qcom-pm8008.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> > index c472d7f8103c..fb8915a682ad 100644
> > --- a/drivers/mfd/qcom-pm8008.c
> > +++ b/drivers/mfd/qcom-pm8008.c
> > @@ -228,8 +228,8 @@ static int pm8008_probe(struct i2c_client *client)
> >  
> >  	chip->dev = &client->dev;
> >  	chip->regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg);
> > -	if (!chip->regmap)
> > -		return -ENODEV;
> > +	if (IS_ERR(chip->regmap))
> > +		return PTR_ERR(chip->regmap);
> >  
> >  	i2c_set_clientdata(client, chip);
> >  
> > -- 
> > 2.25.1
> > 

      reply	other threads:[~2021-06-07 20:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-05  2:24 Yang Yingliang
2021-06-06  3:33 ` Bjorn Andersson
2021-06-07 20:30   ` Guru Das Srinagesh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607203019.GA11347@codeaurora.org \
    --to=gurus@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yangyingliang@huawei.com \
    --subject='Re: [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).