linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe()
@ 2021-06-05  2:24 Yang Yingliang
  2021-06-06  3:33 ` Bjorn Andersson
  0 siblings, 1 reply; 3+ messages in thread
From: Yang Yingliang @ 2021-06-05  2:24 UTC (permalink / raw)
  To: linux-kernel, linux-arm-msm; +Cc: lee.jones, agross, gurus, dmitry.baryshkov

In case of error, the function devm_regmap_init_i2c() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
v3:
  return PTR_ERR(chip->regmap) instead of ENODEV
---
 drivers/mfd/qcom-pm8008.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index c472d7f8103c..fb8915a682ad 100644
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -228,8 +228,8 @@ static int pm8008_probe(struct i2c_client *client)
 
 	chip->dev = &client->dev;
 	chip->regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg);
-	if (!chip->regmap)
-		return -ENODEV;
+	if (IS_ERR(chip->regmap))
+		return PTR_ERR(chip->regmap);
 
 	i2c_set_clientdata(client, chip);
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe()
  2021-06-05  2:24 [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe() Yang Yingliang
@ 2021-06-06  3:33 ` Bjorn Andersson
  2021-06-07 20:30   ` Guru Das Srinagesh
  0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2021-06-06  3:33 UTC (permalink / raw)
  To: Yang Yingliang
  Cc: linux-kernel, linux-arm-msm, lee.jones, agross, gurus, dmitry.baryshkov

On Fri 04 Jun 21:24 CDT 2021, Yang Yingliang wrote:

> In case of error, the function devm_regmap_init_i2c() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
> 
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
> v3:
>   return PTR_ERR(chip->regmap) instead of ENODEV
> ---
>  drivers/mfd/qcom-pm8008.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index c472d7f8103c..fb8915a682ad 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -228,8 +228,8 @@ static int pm8008_probe(struct i2c_client *client)
>  
>  	chip->dev = &client->dev;
>  	chip->regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg);
> -	if (!chip->regmap)
> -		return -ENODEV;
> +	if (IS_ERR(chip->regmap))
> +		return PTR_ERR(chip->regmap);
>  
>  	i2c_set_clientdata(client, chip);
>  
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe()
  2021-06-06  3:33 ` Bjorn Andersson
@ 2021-06-07 20:30   ` Guru Das Srinagesh
  0 siblings, 0 replies; 3+ messages in thread
From: Guru Das Srinagesh @ 2021-06-07 20:30 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Yang Yingliang, linux-kernel, linux-arm-msm, lee.jones, agross,
	dmitry.baryshkov

On Sat, Jun 05, 2021 at 10:33:44PM -0500, Bjorn Andersson wrote:
> On Fri 04 Jun 21:24 CDT 2021, Yang Yingliang wrote:
> 
> > In case of error, the function devm_regmap_init_i2c() returns ERR_PTR()
> > and never returns NULL. The NULL test in the return value check
> > should be replaced with IS_ERR().
> > 
> > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Acked-by: Guru Das Srinagesh <gurus@codeaurora.org>

> 
> > ---
> > v3:
> >   return PTR_ERR(chip->regmap) instead of ENODEV
> > ---
> >  drivers/mfd/qcom-pm8008.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> > index c472d7f8103c..fb8915a682ad 100644
> > --- a/drivers/mfd/qcom-pm8008.c
> > +++ b/drivers/mfd/qcom-pm8008.c
> > @@ -228,8 +228,8 @@ static int pm8008_probe(struct i2c_client *client)
> >  
> >  	chip->dev = &client->dev;
> >  	chip->regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg);
> > -	if (!chip->regmap)
> > -		return -ENODEV;
> > +	if (IS_ERR(chip->regmap))
> > +		return PTR_ERR(chip->regmap);
> >  
> >  	i2c_set_clientdata(client, chip);
> >  
> > -- 
> > 2.25.1
> > 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-07 20:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-05  2:24 [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe() Yang Yingliang
2021-06-06  3:33 ` Bjorn Andersson
2021-06-07 20:30   ` Guru Das Srinagesh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).