From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB89DC47094 for ; Mon, 7 Jun 2021 20:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D213161159 for ; Mon, 7 Jun 2021 20:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231364AbhFGUcM (ORCPT ); Mon, 7 Jun 2021 16:32:12 -0400 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:8956 "EHLO alexa-out-sd-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230251AbhFGUcM (ORCPT ); Mon, 7 Jun 2021 16:32:12 -0400 Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 07 Jun 2021 13:30:20 -0700 X-QCInternal: smtphost Received: from gurus-linux.qualcomm.com ([10.134.64.25]) by ironmsg02-sd.qualcomm.com with ESMTP; 07 Jun 2021 13:30:19 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id A3DE4210F1; Mon, 7 Jun 2021 13:30:19 -0700 (PDT) Date: Mon, 7 Jun 2021 13:30:19 -0700 From: Guru Das Srinagesh To: Bjorn Andersson Cc: Yang Yingliang , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, lee.jones@linaro.org, agross@kernel.org, dmitry.baryshkov@linaro.org Subject: Re: [PATCH net-next v3] mfd: pm8008: Fix return value check in pm8008_probe() Message-ID: <20210607203019.GA11347@codeaurora.org> References: <20210605022446.4119978-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat, Jun 05, 2021 at 10:33:44PM -0500, Bjorn Andersson wrote: > On Fri 04 Jun 21:24 CDT 2021, Yang Yingliang wrote: > > > In case of error, the function devm_regmap_init_i2c() returns ERR_PTR() > > and never returns NULL. The NULL test in the return value check > > should be replaced with IS_ERR(). > > > > Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC") > > Reported-by: Hulk Robot > > Signed-off-by: Yang Yingliang > > Reviewed-by: Bjorn Andersson Acked-by: Guru Das Srinagesh > > > --- > > v3: > > return PTR_ERR(chip->regmap) instead of ENODEV > > --- > > drivers/mfd/qcom-pm8008.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c > > index c472d7f8103c..fb8915a682ad 100644 > > --- a/drivers/mfd/qcom-pm8008.c > > +++ b/drivers/mfd/qcom-pm8008.c > > @@ -228,8 +228,8 @@ static int pm8008_probe(struct i2c_client *client) > > > > chip->dev = &client->dev; > > chip->regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg); > > - if (!chip->regmap) > > - return -ENODEV; > > + if (IS_ERR(chip->regmap)) > > + return PTR_ERR(chip->regmap); > > > > i2c_set_clientdata(client, chip); > > > > -- > > 2.25.1 > >