* [PATCH v2] clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare
@ 2021-06-09 2:28 Jonathan Marek
2021-06-28 2:35 ` Stephen Boyd
2021-06-28 10:55 ` Taniya Das
0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Marek @ 2021-06-09 2:28 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Michael Turquette, Stephen Boyd,
Taniya Das, open list:COMMON CLK FRAMEWORK, open list
Caught this when looking at alpha-pll code. Untested but it is clear that
this was intended to write to PLL_CAL_L_VAL and not PLL_ALPHA_VAL.
Fixes: 691865bad627 ("clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
drivers/clk/qcom/clk-alpha-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
index 94b53c7db2f7f..eaedcceb766f9 100644
--- a/drivers/clk/qcom/clk-alpha-pll.c
+++ b/drivers/clk/qcom/clk-alpha-pll.c
@@ -1255,7 +1255,7 @@ static int alpha_pll_fabia_prepare(struct clk_hw *hw)
return ret;
/* Setup PLL for calibration frequency */
- regmap_write(pll->clkr.regmap, PLL_ALPHA_VAL(pll), cal_l);
+ regmap_write(pll->clkr.regmap, PLL_CAL_L_VAL(pll), cal_l);
/* Bringup the PLL at calibration frequency */
ret = clk_alpha_pll_enable(hw);
--
2.26.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare
2021-06-09 2:28 [PATCH v2] clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare Jonathan Marek
@ 2021-06-28 2:35 ` Stephen Boyd
2021-06-28 10:55 ` Taniya Das
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-06-28 2:35 UTC (permalink / raw)
To: Jonathan Marek, linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Michael Turquette, Taniya Das,
linux-clk, linux-kernel
Quoting Jonathan Marek (2021-06-08 19:28:52)
> Caught this when looking at alpha-pll code. Untested but it is clear that
> this was intended to write to PLL_CAL_L_VAL and not PLL_ALPHA_VAL.
>
> Fixes: 691865bad627 ("clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
Applied to clk-next
Taniya, can you please review?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare
2021-06-09 2:28 [PATCH v2] clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare Jonathan Marek
2021-06-28 2:35 ` Stephen Boyd
@ 2021-06-28 10:55 ` Taniya Das
1 sibling, 0 replies; 3+ messages in thread
From: Taniya Das @ 2021-06-28 10:55 UTC (permalink / raw)
To: Jonathan Marek, linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Michael Turquette, Stephen Boyd,
open list:COMMON CLK FRAMEWORK, open list
Reviewed-by: Taniya Das <tdas@codeaurora.org>
On 6/9/2021 7:58 AM, Jonathan Marek wrote:
> Caught this when looking at alpha-pll code. Untested but it is clear that
> this was intended to write to PLL_CAL_L_VAL and not PLL_ALPHA_VAL.
>
> Fixes: 691865bad627 ("clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> drivers/clk/qcom/clk-alpha-pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
> index 94b53c7db2f7f..eaedcceb766f9 100644
> --- a/drivers/clk/qcom/clk-alpha-pll.c
> +++ b/drivers/clk/qcom/clk-alpha-pll.c
> @@ -1255,7 +1255,7 @@ static int alpha_pll_fabia_prepare(struct clk_hw *hw)
> return ret;
>
> /* Setup PLL for calibration frequency */
> - regmap_write(pll->clkr.regmap, PLL_ALPHA_VAL(pll), cal_l);
> + regmap_write(pll->clkr.regmap, PLL_CAL_L_VAL(pll), cal_l);
>
> /* Bringup the PLL at calibration frequency */
> ret = clk_alpha_pll_enable(hw);
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-28 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 2:28 [PATCH v2] clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare Jonathan Marek
2021-06-28 2:35 ` Stephen Boyd
2021-06-28 10:55 ` Taniya Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).