From: Manivannan Sadhasivam <email@example.com> To: Jakub Kicinski <firstname.lastname@example.org> Cc: Loic Poulain <email@example.com>, David Miller <firstname.lastname@example.org>, Hemant Kumar <email@example.com>, linux-arm-msm <firstname.lastname@example.org>, Bhaumik Bhatt <email@example.com>, Network Development <firstname.lastname@example.org> Subject: Re: [PATCH v2] bus: mhi: Add inbound buffers allocation flag Date: Sat, 12 Jun 2021 12:17:22 +0530 [thread overview] Message-ID: <20210612064722.GA22149@thinkpad> (raw) In-Reply-To: <email@example.com> On Fri, Jun 11, 2021 at 11:31:17AM -0700, Jakub Kicinski wrote: > On Fri, 11 Jun 2021 09:00:16 +0200 Loic Poulain wrote: > > > On Fri, May 21, 2021 at 03:25:19PM +0200, Loic Poulain wrote: > > > > Currently, the MHI controller driver defines which channels should > > > > have their inbound buffers allocated and queued. But ideally, this is > > > > something that should be decided by the MHI device driver instead, > > > > which actually deals with that buffers. > > > > > > > > Add a flag parameter to mhi_prepare_for_transfer allowing to specify > > > > if buffers have to be allocated and queued by the MHI stack. > > > > > > > > Keep auto_queue flag for now, but should be removed at some point. > > > > > > > > Signed-off-by: Loic Poulain <firstname.lastname@example.org> > > > > Tested-by: Bhaumik Bhatt <email@example.com> > > > > Reviewed-by: Bhaumik Bhatt <firstname.lastname@example.org> > > > > Reviewed-by: Hemant Kumar <email@example.com> > > > > Reviewed-by: Manivannan Sadhasivam <firstname.lastname@example.org> > > > > --- > > > > v2: Update API in mhi_wwan_ctrl driver > > > > > > > > drivers/bus/mhi/core/internal.h | 2 +- > > > > drivers/bus/mhi/core/main.c | 11 ++++++++--- > > > > drivers/net/mhi/net.c | 2 +- > > > > drivers/net/wwan/mhi_wwan_ctrl.c | 2 +- > > > > > > Since this patch touches the drivers under net/, I need an Ack from Dave or > > > Jakub to take it via MHI tree. > > > > Could you please ack|nack this patch? > > Looks fine. Thanks, I'll take it as an Ack. Regards, Mani
next prev parent reply other threads:[~2021-06-12 6:47 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-21 13:25 Loic Poulain 2021-05-21 16:35 ` Manivannan Sadhasivam 2021-06-11 7:00 ` Loic Poulain 2021-06-11 18:31 ` Jakub Kicinski 2021-06-12 6:47 ` Manivannan Sadhasivam [this message] 2021-06-12 6:52 ` Manivannan Sadhasivam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210612064722.GA22149@thinkpad \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2] bus: mhi: Add inbound buffers allocation flag' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).