From: Manivannan Sadhasivam <email@example.com>
To: Om Prakash Singh <firstname.lastname@example.org>
Cc: email@example.com, firstname.lastname@example.org, email@example.com,
Subject: Re: [PATCH 0/5] PCI: endpoint: Add support for additional notifiers
Date: Thu, 17 Jun 2021 22:35:50 +0530 [thread overview]
Message-ID: <20210617170549.GA3075@workstation> (raw)
On Thu, Jun 17, 2021 at 12:42:07AM +0530, Om Prakash Singh wrote:
> Hi Mani,
> Adding more notifier types will surely help but I believe the list is not
> exhaustive. What you are trying here is to pass various vendor-specific epc
> interrupts to EPF driver. That can be taken care by a single notifier
> interface as well, "pci_epc_custom_notify" from your implementation.
That's what I initially thought eventhough not all the notifiers are
vendor specific. But Kishon suggested to add notifiers for generic ones
such as BME, PME etc... and that sounded reasonable to me.
> also requires to have pre-defined values of "data" argument to standardize
> the interface.
No, I don't think we can standardize the arguments to "custom" notifier.
The custom notifier is supposed to deal with vendor specific events and
I don't see any benefit on standardizing it. I see it more like an
opaque driver_data field where we pass driver specific arguments.
> your thoughts?
> On 6/16/2021 5:29 PM, Manivannan Sadhasivam wrote:
> > External email: Use caution opening links or attachments
> > Hello,
> > This series adds support for additional notifiers in the PCI endpoint
> > framework. The notifiers LINK_DOWN, BME, PME, and D_STATE are generic
> > for all PCI endpoints but there is also a custom notifier (CUSTOM) added
> > to pass the device/vendor specific events to EPF from EPC.
> > The example usage of all notifiers is provided in the commit description.
> > Thanks,
> > Mani
> > Manivannan Sadhasivam (5):
> > PCI: endpoint: Add linkdown notifier support
> > PCI: endpoint: Add BME notifier support
> > PCI: endpoint: Add PME notifier support
> > PCI: endpoint: Add D_STATE notifier support
> > PCI: endpoint: Add custom notifier support
> > drivers/pci/endpoint/pci-epc-core.c | 89 +++++++++++++++++++++++++++++
> > include/linux/pci-epc.h | 5 ++
> > include/linux/pci-epf.h | 5 ++
> > 3 files changed, 99 insertions(+)
> > --
> > 2.25.1
next prev parent reply other threads:[~2021-06-17 17:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 11:59 [PATCH 0/5] PCI: endpoint: Add support for additional notifiers Manivannan Sadhasivam
2021-06-16 11:59 ` [PATCH 1/5] PCI: endpoint: Add linkdown notifier support Manivannan Sadhasivam
2021-06-16 18:22 ` Om Prakash Singh
2021-06-16 18:30 ` Manivannan Sadhasivam
2021-06-16 11:59 ` [PATCH 2/5] PCI: endpoint: Add BME " Manivannan Sadhasivam
2021-06-16 11:59 ` [PATCH 3/5] PCI: endpoint: Add PME " Manivannan Sadhasivam
2021-06-16 11:59 ` [PATCH 4/5] PCI: endpoint: Add D_STATE " Manivannan Sadhasivam
2021-06-16 11:59 ` [PATCH 5/5] PCI: endpoint: Add custom " Manivannan Sadhasivam
2021-06-16 19:12 ` [PATCH 0/5] PCI: endpoint: Add support for additional notifiers Om Prakash Singh
2021-06-17 17:05 ` Manivannan Sadhasivam [this message]
2021-08-19 13:06 ` Manivannan Sadhasivam
2021-08-19 14:15 ` Kishon Vijay Abraham I
2021-08-19 14:22 ` Manivannan Sadhasivam
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).