From: Manivannan Sadhasivam <email@example.com> To: Bhaumik Bhatt <firstname.lastname@example.org> Cc: Kalle Valo <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v4 4/6] ath11k: set register access length for MHI driver Date: Fri, 18 Jun 2021 12:15:14 +0530 [thread overview] Message-ID: <20210618064514.GM3682@workstation> (raw) In-Reply-To: <firstname.lastname@example.org> On Wed, Jun 16, 2021 at 10:38:01AM -0700, Bhaumik Bhatt wrote: > Hi Kalle/Mani, > > On 2021-06-14 10:49 AM, Bhaumik Bhatt wrote: > > Hi Kalle, > > > > On 2021-06-14 09:02 AM, Kalle Valo wrote: > > > Manivannan Sadhasivam <email@example.com> writes: > > > > > > > On Thu, May 06, 2021 at 12:51:43PM -0700, Bhaumik Bhatt wrote: > > > > > MHI driver requires register space length to add range checks and > > > > > prevent memory region accesses outside of that for MMIO space. > > > > > Set it before registering the MHI controller. > > > > > > > > > > Signed-off-by: Bhaumik Bhatt <firstname.lastname@example.org> > > > > > Reviewed-by: Hemant Kumar <email@example.com> > > > > > > > > Reviewed-by: Manivannan Sadhasivam <firstname.lastname@example.org> > > > > > > > > Kalle, should we do immutable branch for this patch or I can > > > > pick it up via MHI > > > > tree (if there are no other patches expected from ath11k for > > > > this controller)? > > > > > > I'm not expecting any conflicts with this, and if there are, they > > > should > > > be easy for Stephen or Linus to fix. So it's easiest to route this via > > > your tree. But I'm not giving my ack yet, see below. > > > > > > I'm worried that this patchset breaks bisect. Every patch in the > > > patchset should not break existing functionality, what if only patches > > > 1-3 are included in the tree but not patch 4? Wouldn't ath11k be > > > broken > > > then? I didn't review the whole patchset, but I suspect the fix is to > > > include the ath11k change in the actual mhi patch which changes the > > > functionality. So that way we would not have a separate ath11k patch > > > at > > > all. > > > > > > Also I'm not able to test this patchset at the moment. Can someone > > > else > > > help and do a quick test with QCA6390 to verify these doesn't break > > > ath11k? > > > > I have requested someone to try and test this patch series with QCA6390. > > > > I or the testers will get back to you with the test results when they > > are > > available. > > > > As far as your concerns go, you can choose to pick patches 1-3 and that > > would > > be just fine. > > > > Things will break if patchset 4 is _not_ in place with patchset 6 being > > part of > > the tree. > > > > It would, however, be nice to pick the whole series instead and ensure > > that > > the functionality MHI introduces for boot-up sanity is in place for any > > controllers such as ath11k. > > > > Thanks, > > Bhaumik > > --- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > > Forum, > > a Linux Foundation Collaborative Project > > Just got confirmation that the whole patch series was tested for functional > sanity on > Dell E7590 + QCA6390 with Ubuntu18.04 and patch 4/6 is also good to go. > > Can you please ACK and pick up this series? > I can pick the series but I need an Ack from Kalle since it contains ath11k changes. Kalle, can you please Ack this patch? I'm planning to send the PR by this weekend. Thanks, Mani > Thanks, > Bhaumik > --- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-06-18 6:45 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-06 19:51 [PATCH v4 0/6] BHI/BHIe improvements for MHI power purposes Bhaumik Bhatt 2021-05-06 19:51 ` [PATCH v4 1/6] bus: mhi: core: Set BHI/BHIe offsets on power up preparation Bhaumik Bhatt 2021-05-21 13:36 ` Manivannan Sadhasivam 2021-05-06 19:51 ` [PATCH v4 2/6] bus: mhi: core: Set BHI and BHIe pointers to NULL in clean-up Bhaumik Bhatt 2021-05-21 13:37 ` Manivannan Sadhasivam 2021-05-06 19:51 ` [PATCH v4 3/6] bus: mhi: Add MMIO region length to controller structure Bhaumik Bhatt 2021-05-21 13:38 ` Manivannan Sadhasivam 2021-05-06 19:51 ` [PATCH v4 4/6] ath11k: set register access length for MHI driver Bhaumik Bhatt 2021-05-21 13:51 ` Manivannan Sadhasivam 2021-06-14 16:02 ` Kalle Valo 2021-06-14 17:49 ` Bhaumik Bhatt 2021-06-16 17:38 ` Bhaumik Bhatt 2021-06-18 6:45 ` Manivannan Sadhasivam [this message] 2021-06-23 17:29 ` Kalle Valo 2021-06-24 6:09 ` Manivannan Sadhasivam 2021-06-23 17:34 ` Kalle Valo 2021-06-23 21:33 ` Bhaumik Bhatt 2021-05-06 19:51 ` [PATCH v4 5/6] bus: mhi: pci_generic: Set " Bhaumik Bhatt 2021-05-21 13:52 ` Manivannan Sadhasivam 2021-05-06 19:51 ` [PATCH v4 6/6] bus: mhi: core: Add range checks for BHI and BHIe Bhaumik Bhatt 2021-05-07 2:33 ` Hemant Kumar 2021-05-21 13:54 ` Manivannan Sadhasivam 2021-06-25 5:28 ` [PATCH v4 0/6] BHI/BHIe improvements for MHI power purposes Manivannan Sadhasivam -- strict thread matches above, loose matches on Subject: below -- 2021-05-06 19:32 Bhaumik Bhatt 2021-05-06 19:32 ` [PATCH v4 4/6] ath11k: set register access length for MHI driver Bhaumik Bhatt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210618064514.GM3682@workstation \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v4 4/6] ath11k: set register access length for MHI driver' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).