From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F26C8C2B9F4 for ; Sat, 19 Jun 2021 04:41:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C746461284 for ; Sat, 19 Jun 2021 04:41:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229971AbhFSEnZ (ORCPT ); Sat, 19 Jun 2021 00:43:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232965AbhFSEnY (ORCPT ); Sat, 19 Jun 2021 00:43:24 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F7C1C061574 for ; Fri, 18 Jun 2021 21:41:12 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id y4so2302875pfi.9 for ; Fri, 18 Jun 2021 21:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=L+FkwuKoKiTPSoSjVlEsRP6H4c6gq5WUFtj0/g0L8iw=; b=BPKaVlyFFNrMbLIyT5/ssBznlQHvvlhArZbGZcAQdZp1hDyZoeP1C1tb0+DplIcY9i HUP9GK9CRVLyM+EaFUv+iIZAUbrKNvdpLwj7QeaKFWlRDRYGdqZH6OVHBcMoVZEuLwuW y8ZZfi2AqfytK0uIXfEfWmD8THwl25h6nsP3V6/2T8By/zkrmH8qb5LI7NgFdUG4lnCT Fb/lEnkuhfVg7OoVevrGhNwr+vH7GhdJygFvPtFpCq9TP4SyoPCtRgtDlW1R8tKliFf5 Ok3ryGFiMA5EZExlj6IppDpDRxnxTlo1R4ibuZWVUdhGIOe8ukQhYqQUoj9nxwuS+11t TrXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=L+FkwuKoKiTPSoSjVlEsRP6H4c6gq5WUFtj0/g0L8iw=; b=aQ4ZTGr6NWJYN+6Nv5XhxLqVDQ8ZyOZaj13lHX4tMHM6h1BSt1Xx3js86TxBfYN7oB 56hddJRfX4omXx+Evmk/OfLwPKe3Dzmf4kJbRcR2/WfZRVyT3Jhs71/8LyZyixjrXw4r lfXleUvHFPecG/ZDLoe3hzU8JzZV8+IwYrTfL/M2Dki+ElJv3PsIOhjNevsJDd+4QKuO 0t+4zle0m8Rxgo715rTJMtQfxFQVNnqWbOFiHGXLqNohj4aGoB2/VOwKMzD91nEAtlVW tzCvH7ns59AqzsBqnEDQetX51BDRSsboP2KH1bWMn47YCyGA5aA6nGPWQzWosuWXqbBQ RvXA== X-Gm-Message-State: AOAM5303H0ueDGWiNoarR1pdYej+Y3X4kmvtwy0CnU8EYM/R4pGFRdjq hGihhUPHVdWq/PtbyOwHT4eI X-Google-Smtp-Source: ABdhPJxSTRhdopdhslvzxn3+uPeYSgdTaw/74YCyMv9DhLc9/WvHi67mBrWQDGiot26tNlJ5Y2LhuA== X-Received: by 2002:a05:6a00:1146:b029:2fe:d681:fbcc with SMTP id b6-20020a056a001146b02902fed681fbccmr8592085pfm.31.1624077671932; Fri, 18 Jun 2021 21:41:11 -0700 (PDT) Received: from workstation ([120.138.12.53]) by smtp.gmail.com with ESMTPSA id q4sm9487870pfg.3.2021.06.18.21.41.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Jun 2021 21:41:11 -0700 (PDT) Date: Sat, 19 Jun 2021 10:11:07 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, carl.yin@quectel.com, naveen.kumar@quectel.com, loic.poulain@linaro.org Subject: Re: [PATCH v2] bus: mhi: pci_generic: Apply no-op for wake using sideband wake boolean Message-ID: <20210619044107.GB4889@workstation> References: <1624053302-22470-1-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1624053302-22470-1-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jun 18, 2021 at 02:55:02PM -0700, Bhaumik Bhatt wrote: > Devices such as SDX24 do not have the provision for inband wake > doorbell in the form of channel 127 and instead have a sideband > GPIO for it. Newer devices such as SDX55 or SDX65 support inband > wake method by default. Ensure the functionality is used based on > this such that device wake stays held when a client driver uses > mhi_device_get() API or the equivalent debugfs entry. > > Fixes: e3e5e6508fc1 ("bus: mhi: pci_generic: No-Op for device_wake operations") > Signed-off-by: Bhaumik Bhatt One minor nit below but I'll fix it while applying. Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > v2: Use sideband instead of no_inband_wake and update description > Tested on: X86_64 architecture with SDX65 device on Ubuntu 18.04 > > drivers/bus/mhi/pci_generic.c | 26 ++++++++++++++++++-------- > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c > index d84b743..56f7107 100644 > --- a/drivers/bus/mhi/pci_generic.c > +++ b/drivers/bus/mhi/pci_generic.c > @@ -32,6 +32,7 @@ > * @edl: emergency download mode firmware path (if any) > * @bar_num: PCI base address register to use for MHI MMIO register space > * @dma_data_width: DMA transfer word size (32 or 64 bits) > + * @sideband_wake: Devices without inband wake support (such as sdx24) Will change to: @sideband_wake: Devices using dedicated sideband GPIO for wakeup instead of inband wake support (such as sdx24) > */ > struct mhi_pci_dev_info { > const struct mhi_controller_config *config; > @@ -40,6 +41,7 @@ struct mhi_pci_dev_info { > const char *edl; > unsigned int bar_num; > unsigned int dma_data_width; > + bool sideband_wake; > }; > > #define MHI_CHANNEL_CONFIG_UL(ch_num, ch_name, el_count, ev_ring) \ > @@ -242,7 +244,8 @@ static const struct mhi_pci_dev_info mhi_qcom_sdx65_info = { > .edl = "qcom/sdx65m/edl.mbn", > .config = &modem_qcom_v1_mhiv_config, > .bar_num = MHI_PCI_DEFAULT_BAR_NUM, > - .dma_data_width = 32 > + .dma_data_width = 32, > + .sideband_wake = false > }; > > static const struct mhi_pci_dev_info mhi_qcom_sdx55_info = { > @@ -251,7 +254,8 @@ static const struct mhi_pci_dev_info mhi_qcom_sdx55_info = { > .edl = "qcom/sdx55m/edl.mbn", > .config = &modem_qcom_v1_mhiv_config, > .bar_num = MHI_PCI_DEFAULT_BAR_NUM, > - .dma_data_width = 32 > + .dma_data_width = 32, > + .sideband_wake = false > }; > > static const struct mhi_pci_dev_info mhi_qcom_sdx24_info = { > @@ -259,7 +263,8 @@ static const struct mhi_pci_dev_info mhi_qcom_sdx24_info = { > .edl = "qcom/prog_firehose_sdx24.mbn", > .config = &modem_qcom_v1_mhiv_config, > .bar_num = MHI_PCI_DEFAULT_BAR_NUM, > - .dma_data_width = 32 > + .dma_data_width = 32, > + .sideband_wake = true > }; > > static const struct mhi_channel_config mhi_quectel_em1xx_channels[] = { > @@ -301,7 +306,8 @@ static const struct mhi_pci_dev_info mhi_quectel_em1xx_info = { > .edl = "qcom/prog_firehose_sdx24.mbn", > .config = &modem_quectel_em1xx_config, > .bar_num = MHI_PCI_DEFAULT_BAR_NUM, > - .dma_data_width = 32 > + .dma_data_width = 32, > + .sideband_wake = true > }; > > static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = { > @@ -339,7 +345,8 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = { > .edl = "qcom/sdx55m/edl.mbn", > .config = &modem_foxconn_sdx55_config, > .bar_num = MHI_PCI_DEFAULT_BAR_NUM, > - .dma_data_width = 32 > + .dma_data_width = 32, > + .sideband_wake = false > }; > > static const struct pci_device_id mhi_pci_id_table[] = { > @@ -640,9 +647,12 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > mhi_cntrl->status_cb = mhi_pci_status_cb; > mhi_cntrl->runtime_get = mhi_pci_runtime_get; > mhi_cntrl->runtime_put = mhi_pci_runtime_put; > - mhi_cntrl->wake_get = mhi_pci_wake_get_nop; > - mhi_cntrl->wake_put = mhi_pci_wake_put_nop; > - mhi_cntrl->wake_toggle = mhi_pci_wake_toggle_nop; > + > + if (info->sideband_wake) { > + mhi_cntrl->wake_get = mhi_pci_wake_get_nop; > + mhi_cntrl->wake_put = mhi_pci_wake_put_nop; > + mhi_cntrl->wake_toggle = mhi_pci_wake_toggle_nop; > + } > > err = mhi_pci_claim(mhi_cntrl, info->bar_num, DMA_BIT_MASK(info->dma_data_width)); > if (err) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >