linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "manivannan.sadhasivam@linaro.org" <manivannan.sadhasivam@linaro.org>
To: ULRICH Thomas <thomas.ulrich@thalesgroup.com>
Cc: "hemantk@codeaurora.org" <hemantk@codeaurora.org>,
	SCHEMMEL Hans-Christoph <hans-christoph.schemmel@thalesgroup.com>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] Add Cinterion MV31-W PCIe to MHI
Date: Mon, 21 Jun 2021 21:14:22 +0530	[thread overview]
Message-ID: <20210621154422.GB20545@workstation> (raw)
In-Reply-To: <20210621151629.GA20545@workstation>

On Mon, Jun 21, 2021 at 08:46:29PM +0530, manivannan.sadhasivam@linaro.org wrote:
> + linux-arm-msm
> 
> On Mon, Jun 21, 2021 at 09:04:17AM +0000, ULRICH Thomas wrote:
> > This patch adds VendorID/ProductID and MBIM Channel Definitions for M.2 Modem Card (PCIe Variant) to MHI:
> > Cinterion MV31-W (by Thales)
> > Additional information on such Modem Card (USB or PCIe variant) is e.g. available at:
> > https://www.thalesgroup.com/en/markets/digital-identity-and-security/iot/iot-connectivity/products/iot-products/mv31-w-ultra-high
> > 
> > Signed-off-by: Thomas Ulrich <thomas.ulrich@thalesgroup.com>
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 

There were multiple checkpatch errors while trying to apply this patch.
But I just fixed them and applied. Please make sure to run checkpatch.pl
script for future patches.

Thanks,
Mani

> > 
> > ---
> >  drivers/bus/mhi/pci_generic.c | 37 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> > 
> > diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> > index 56f710763e36..5e263794d4c5 100644
> > --- a/drivers/bus/mhi/pci_generic.c
> > +++ b/drivers/bus/mhi/pci_generic.c
> 
> [...]
> 
> > +static const struct mhi_pci_dev_info mhi_mv31_info = {
> > +        .name = "cinterion-mv31",
> > +        .config = &modem_mv31_config,
> > +        .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> > +        .dma_data_width = 32
> 
> As per 704d98540e55, there needs to be:
> 
> 	.sideband_wake = false,
> 
> I'll add it while applying.
> 
> Thanks,
> Mani
> 
> > +};
> > +
> >  static const struct pci_device_id mhi_pci_id_table[] = {
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0306),
> >  		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx55_info },
> > @@ -369,6 +403,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> >  	/* DW5930e (sdx55), Non-eSIM, It's also T99W175 */
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0b1),
> >  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> > +        /* MV31-W (Cinterion) */
> > +        { PCI_DEVICE(0x1269, 0x00b3),
> > +                .driver_data = (kernel_ulong_t) &mhi_mv31_info },
> >  	{  }
> >  };
> >  MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
> > -- 
> > 2.20.1
> > 

      reply	other threads:[~2021-06-21 15:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <PAZP264MB284690134DA010698E6B3BDDE60A9@PAZP264MB2846.FRAP264.PROD.OUTLOOK.COM>
2021-06-21 15:16 ` [PATCH] Add Cinterion MV31-W PCIe to MHI manivannan.sadhasivam
2021-06-21 15:44   ` manivannan.sadhasivam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621154422.GB20545@workstation \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=hans-christoph.schemmel@thalesgroup.com \
    --cc=hemantk@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=thomas.ulrich@thalesgroup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).