From: Paul Davey <paul.davey@alliedtelesis.co.nz>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Bhaumik Bhatt <bbhatt@codeaurora.org>,
Hemant Kumar <hemantk@codeaurora.org>,
Paul Davey <paul.davey@alliedtelesis.co.nz>
Subject: [PATCH v2 1/2] bus: mhi: Fix pm_state conversion to string
Date: Wed, 23 Jun 2021 14:43:26 +1200 [thread overview]
Message-ID: <20210623024327.15029-2-paul.davey@alliedtelesis.co.nz> (raw)
In-Reply-To: <20210623024327.15029-1-paul.davey@alliedtelesis.co.nz>
On big endian architectures the mhi debugfs files which report pm state
give "Invalid State" for all states. This is caused by using
find_last_bit which takes an unsigned long* while the state is passed in
as an enum mhi_pm_state which will be of int size.
Fix by using __fls to pass the value of state instead of find_last_bit.
Signed-off-by: Paul Davey <paul.davey@alliedtelesis.co.nz>
---
Not adding Tested-by or Reviewed-by tags as this patch has changed
substantially from v1.
drivers/bus/mhi/core/init.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index c81b377fca8f..0706eb046f2a 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -79,9 +79,12 @@ static const char * const mhi_pm_state_str[] = {
const char *to_mhi_pm_state_str(enum mhi_pm_state state)
{
- int index = find_last_bit((unsigned long *)&state, 32);
+ int index;
- if (index >= ARRAY_SIZE(mhi_pm_state_str))
+ if (state)
+ index = __fls(state);
+
+ if (!state || index >= ARRAY_SIZE(mhi_pm_state_str))
return "Invalid State";
return mhi_pm_state_str[index];
--
2.32.0
next prev parent reply other threads:[~2021-06-23 2:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 2:43 [PATCH v2 0/2] bus: mhi: Fix MHI on big endian architectures Paul Davey
2021-06-23 2:43 ` Paul Davey [this message]
2021-06-23 2:43 ` [PATCH v2 2/2] bus: mhi: Fix MHI DMA structure endianness Paul Davey
2021-06-24 2:11 ` Bhaumik Bhatt
2021-06-24 23:12 ` Paul Davey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623024327.15029-2-paul.davey@alliedtelesis.co.nz \
--to=paul.davey@alliedtelesis.co.nz \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).