linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/4] drm/msm/dpu: always use mdp device to scale bandwidth
@ 2021-08-03 10:16 Dmitry Baryshkov
  2021-08-03 10:16 ` [PATCH v3 1/2] arm64: dts: sdm845: move bus clock to mdp node for sdm845 target Dmitry Baryshkov
  2021-08-03 10:16 ` [PATCH v3 2/2] arm64: dts: sm8250: remove bus clock from the mdss node for sm8250 target Dmitry Baryshkov
  0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2021-08-03 10:16 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Clark, Abhinav Kumar
  Cc: linux-arm-msm, dri-devel, freedreno

In 5.13 the DPU driver was changed to vote on the bus bandwidth for all
the soc families, however suggested [1] dts changes were for some reason
not merged at that time. Let's merge them now.

If the bootloader does not setup the bus vote, clock might not be
enabled before the driver votes on the MDP bus bandwidth. Originally bus
votes were static and happened in MDSS hadling code, while now they are
dynamic and are moved to the MDP handling code, thus bus clocks also
should belong to the MDP device.

[1] https://lore.kernel.org/linux-arm-msm/04b4612dfd3f651ead068725409211a0@codeaurora.org/

Changes since v2:
 - Dropped merged patches
 - Rephrased commit message for sm8250.

Changes since v1:
 - Add dts changes as requested by Kalyan Thota

----------------------------------------------------------------
Dmitry Baryshkov (2):
      arm64: dts: sdm845: move bus clock to mdp node for sdm845 target
      arm64: dts: sm8250: remove bus clock from the mdss node for sm8250 target

 arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++----
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 +--
 2 files changed, 5 insertions(+), 6 deletions(-)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v3 1/2] arm64: dts: sdm845: move bus clock to mdp node for sdm845 target
  2021-08-03 10:16 [PATCH v3 0/4] drm/msm/dpu: always use mdp device to scale bandwidth Dmitry Baryshkov
@ 2021-08-03 10:16 ` Dmitry Baryshkov
  2021-08-03 10:16 ` [PATCH v3 2/2] arm64: dts: sm8250: remove bus clock from the mdss node for sm8250 target Dmitry Baryshkov
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2021-08-03 10:16 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Clark, Abhinav Kumar
  Cc: linux-arm-msm, dri-devel, freedreno

Move the bus clock to mdp device node,in order to facilitate bus band
width scaling on sdm845 target.

The parent device MDSS will not vote for bus bw, instead the vote will
be triggered by mdp device node. Since a minimum vote is required to
turn on bus clock, move the clock node to mdp device from where the
votes are requested.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 1796ae8372be..9e77a323b1cd 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4148,9 +4148,8 @@ mdss: mdss@ae00000 {
 			power-domains = <&dispcc MDSS_GDSC>;
 
 			clocks = <&gcc GCC_DISP_AHB_CLK>,
-				 <&gcc GCC_DISP_AXI_CLK>,
 				 <&dispcc DISP_CC_MDSS_MDP_CLK>;
-			clock-names = "iface", "bus", "core";
+			clock-names = "iface", "core";
 
 			assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
 			assigned-clock-rates = <300000000>;
@@ -4178,11 +4177,12 @@ mdss_mdp: mdp@ae01000 {
 				      <0 0x0aeb0000 0 0x2008>;
 				reg-names = "mdp", "vbif";
 
-				clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
+				clocks = <&gcc GCC_DISP_AXI_CLK>,
+					 <&dispcc DISP_CC_MDSS_AHB_CLK>,
 					 <&dispcc DISP_CC_MDSS_AXI_CLK>,
 					 <&dispcc DISP_CC_MDSS_MDP_CLK>,
 					 <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
-				clock-names = "iface", "bus", "core", "vsync";
+				clock-names = "gcc-bus", "iface", "bus", "core", "vsync";
 
 				assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
 						  <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v3 2/2] arm64: dts: sm8250: remove bus clock from the mdss node for sm8250 target
  2021-08-03 10:16 [PATCH v3 0/4] drm/msm/dpu: always use mdp device to scale bandwidth Dmitry Baryshkov
  2021-08-03 10:16 ` [PATCH v3 1/2] arm64: dts: sdm845: move bus clock to mdp node for sdm845 target Dmitry Baryshkov
@ 2021-08-03 10:16 ` Dmitry Baryshkov
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2021-08-03 10:16 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Rob Clark, Abhinav Kumar
  Cc: linux-arm-msm, dri-devel, freedreno

Remove the bus clock from the mdss device node, in order to facilitate
bus band width scaling on sm8250 target.

The parent device MDSS will not vote for bus bw, instead the vote will
be triggered by mdp device node. Since a minimum vote is required to
turn on bus clock, and since mdp device node already has the bus clock,
remove the clock from the mdss device.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 4798368b02ef..1df03c809d02 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2470,10 +2470,9 @@ mdss: mdss@ae00000 {
 			power-domains = <&dispcc MDSS_GDSC>;
 
 			clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
-				 <&gcc GCC_DISP_HF_AXI_CLK>,
 				 <&gcc GCC_DISP_SF_AXI_CLK>,
 				 <&dispcc DISP_CC_MDSS_MDP_CLK>;
-			clock-names = "iface", "bus", "nrt_bus", "core";
+			clock-names = "iface", "nrt_bus", "core";
 
 			assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
 			assigned-clock-rates = <460000000>;
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-03 10:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-03 10:16 [PATCH v3 0/4] drm/msm/dpu: always use mdp device to scale bandwidth Dmitry Baryshkov
2021-08-03 10:16 ` [PATCH v3 1/2] arm64: dts: sdm845: move bus clock to mdp node for sdm845 target Dmitry Baryshkov
2021-08-03 10:16 ` [PATCH v3 2/2] arm64: dts: sm8250: remove bus clock from the mdss node for sm8250 target Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).