From: Shawn Guo <shawn.guo@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add Truly NT35521 panel support
Date: Fri, 13 Aug 2021 21:59:44 +0800 [thread overview]
Message-ID: <20210813135943.GE6795@dragon> (raw)
In-Reply-To: <YRQcTLK1ffM1TEbX@robh.at.kernel.org>
On Wed, Aug 11, 2021 at 12:51:56PM -0600, Rob Herring wrote:
> On Wed, Aug 04, 2021 at 04:13:51PM +0800, Shawn Guo wrote:
> > The Truly NT35521 is a 5.24" 1280x720 DSI panel, and the backlight is
> > managed through DSI link.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > ---
> > .../bindings/display/panel/truly,nt35521.yaml | 62 +++++++++++++++++++
> > 1 file changed, 62 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml b/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml
> > new file mode 100644
> > index 000000000000..4727c3df6eb8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/truly,nt35521.yaml
> > @@ -0,0 +1,62 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/truly,nt35521.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Truly NT35521 5.24" 1280x720 MIPI-DSI Panel
> > +
> > +maintainers:
> > + - Shawn Guo <shawn.guo@linaro.org>
> > +
> > +description: |
> > + The Truly NT35521 is a 5.24" 1280x720 MIPI-DSI panel. The panel backlight
> > + is managed through DSI link.
> > +
> > +allOf:
> > + - $ref: panel-common.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: truly,nt35521
> > +
> > + reg: true
> > +
> > + reset-gpios: true
> > +
> > + enable-gpios: true
> > +
> > + pwr-positive5-gpios:
> > + maxItems: 1
> > +
> > + pwr-negative5-gpios:
> > + maxItems: 1
>
> Are these +/-5V supplies? If so, they should be modeled with
> gpio-regulator perhaps unless the panel connection could only ever be
> GPIOs.
Hi Rob,
The binding has been updated in v2 [1]. Please help review that.
Thanks!
Shawn
[1] https://lore.kernel.org/linux-arm-msm/20210809051008.6172-2-shawn.guo@linaro.org/T/#m587035a602b1be6c5326dcf24af01b3e8a5d2cc9
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - reset-gpios
> > + - enable-gpios
> > + - pwr-positive5-gpios
> > + - pwr-negative5-gpios
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + dsi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + panel@0 {
> > + compatible = "truly,nt35521";
> > + reg = <0>;
> > + reset-gpios = <&msmgpio 25 GPIO_ACTIVE_LOW>;
> > + pwr-positive5-gpios = <&msmgpio 114 GPIO_ACTIVE_HIGH>;
> > + pwr-negative5-gpios = <&msmgpio 17 GPIO_ACTIVE_HIGH>;
> > + enable-gpios = <&msmgpio 10 GPIO_ACTIVE_HIGH>;
> > + };
> > + };
> > +...
> > --
> > 2.17.1
> >
> >
next prev parent reply other threads:[~2021-08-13 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 8:13 [PATCH 0/2] Add Truly NT35521 panel driver support Shawn Guo
2021-08-04 8:13 ` [PATCH 1/2] dt-bindings: display: panel: Add Truly NT35521 panel support Shawn Guo
[not found] ` <YQq6ascrSCtErWrf@ravnborg.org>
2021-08-08 12:04 ` Shawn Guo
2021-08-11 18:51 ` Rob Herring
2021-08-13 13:59 ` Shawn Guo [this message]
2021-08-04 8:13 ` [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver Shawn Guo
2021-08-04 12:09 ` Stephan Gerhold
2021-08-08 13:44 ` Shawn Guo
2021-08-08 15:29 ` Stephan Gerhold
2021-08-09 4:20 ` Shawn Guo
[not found] ` <YQq/LOWEgTIk9zIT@ravnborg.org>
2021-08-08 13:49 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813135943.GE6795@dragon \
--to=shawn.guo@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).