From: Shawn Guo <shawn.guo@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Manu Gautam <mgautam@codeaurora.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
Jami Kettunen <jamipkettunen@gmail.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,qusb2: Add missing vdd-supply
Date: Mon, 27 Sep 2021 20:30:27 +0800 [thread overview]
Message-ID: <20210927123026.GG9901@dragon> (raw)
In-Reply-To: <20210927044824.30246-2-shawn.guo@linaro.org>
On Mon, Sep 27, 2021 at 12:48:22PM +0800, Shawn Guo wrote:
> Besides vdda-pll and vdda-phy-dpdm, vdd-supply is a required supply for
> PHY digital circuit operation. Add it for correctness and completeness.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> index 48ae604b2194..96e31f582fc9 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> @@ -51,6 +51,10 @@ properties:
> - const: ref
> - const: iface
>
> + vdda-supply:
Oops, it should be `vdd-supply`. Will fix it in v2.
Shawn
> + description:
> + Phandle to 0.9V regulator supply to PHY digital circuit.
> +
> vdda-pll-supply:
> description:
> Phandle to 1.8V regulator supply to PHY refclk pll block.
> @@ -157,6 +161,7 @@ required:
> - "#phy-cells"
> - clocks
> - clock-names
> + - vdd-supply
> - vdda-pll-supply
> - vdda-phy-dpdm-supply
> - resets
> @@ -175,6 +180,7 @@ examples:
> <&gcc GCC_RX1_USB2_CLKREF_CLK>;
> clock-names = "cfg_ahb", "ref";
>
> + vdd-supply = <&pm8994_l28>;
> vdda-pll-supply = <&pm8994_l12>;
> vdda-phy-dpdm-supply = <&pm8994_l24>;
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-09-27 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 4:48 [PATCH 0/3] Add missing vdd-supply for QUSB2 PHY Shawn Guo
2021-09-27 4:48 ` [PATCH 1/3] dt-bindings: phy: qcom,qusb2: Add missing vdd-supply Shawn Guo
2021-09-27 12:23 ` Rob Herring
2021-09-27 12:30 ` Shawn Guo [this message]
2021-09-27 4:48 ` [PATCH 2/3] phy: qcom-qusb2: Add missing vdd supply Shawn Guo
2021-09-27 4:48 ` [PATCH 3/3] arm64: dts: qcom: Add missing vdd-supply for QUSB2 PHY Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927123026.GG9901@dragon \
--to=shawn.guo@linaro.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@gmail.com \
--cc=jeffrey.l.hugo@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mgautam@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).