From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FBBC4332F for ; Tue, 5 Oct 2021 09:05:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC39D61371 for ; Tue, 5 Oct 2021 09:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233174AbhJEJHs (ORCPT ); Tue, 5 Oct 2021 05:07:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233289AbhJEJHs (ORCPT ); Tue, 5 Oct 2021 05:07:48 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 902F6C061753 for ; Tue, 5 Oct 2021 02:05:57 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id m42so5220947wms.2 for ; Tue, 05 Oct 2021 02:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Sch0aWxDBNQdpah51FulP42zKP3FSOyTJMCjs7CVLTM=; b=bY1lQ0osNyWKNqBAua4Kg5sBOYow4ldD0jTiPF6AlazJXq8jACkl3c0roM248Trihg IP1KhGgFlPLVdLbcJ1LQeVgaTZDTX8dl62IlXg5NzbZv3pc/nkiVxgPatKf/tZaHm1dL kWzZPcxsZ1+0mJeUm2cRo7GK1UtZzJCa6edlGwQPdzpIgr6QnEosRGm68aQsotwzRJXF CDbleSXqI0i4BrCEaC5F1nDeuw3Wo75cHlLNBDTaOZrwrqkmq0tiaCjWf2eIqL13yYp3 wOpHJgeVAURft6aB7hMKER+PDuAzkvCD3WYlBBpsOe5ccbcbMWKY+sZV6UI69i1B+isa q/4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Sch0aWxDBNQdpah51FulP42zKP3FSOyTJMCjs7CVLTM=; b=hzBvjZXPxT0ckXcv6Fhm+AgmqQ9yFNi+aJZ07P9AmP6fJGUIrhSYSazTOLhJ8orPOg 8FPYR1ytoLCbLJkvU5reMlT8qQ52TrdHcgZQmyYynM7OgfsGCBNiMKvyb0EDrLwhD32z dWtDD7pvvy+usRWm2QsW6fD+Gi+jRSGV0SCuPCeO1KW5pXPw3Qi+cw2tG1im06mXekdT FaBgkMJkmRNrS45XIpvHbCPvhlUxE6nfjc5YrCsgq+kO2NOdXQ7eAS/K8LKi8PdezFsQ jotGpbejZ5pWvE5ahihY1GixFjecyW6jBL4EiYhAWJmyOAH2gWJprKBPK+c/rs75szvH YJdQ== X-Gm-Message-State: AOAM531ISXkpVg/HrSPWhV5OnubB1sFymRNxvrz3R9Aq96nTb8LNjmXH OuKhZbgeBnMOvenwYw9A1/zIXw== X-Google-Smtp-Source: ABdhPJxihmBnUHQnbQ4fyua0XZJasSFmZfAkJOHSSqxnk0Vb1yLrCSgSEA7VR57yIqbCyZjlKhl21w== X-Received: by 2002:a05:600c:4e86:: with SMTP id f6mr2195141wmq.52.1633424756122; Tue, 05 Oct 2021 02:05:56 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id k9sm16658777wrz.22.2021.10.05.02.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 02:05:55 -0700 (PDT) Date: Tue, 5 Oct 2021 10:05:53 +0100 From: Daniel Thompson To: Marijn Suijten Cc: phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Lee Jones , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Courtney Cavin , Bryan Wu , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] backlight: qcom-wled: Pass number of elements to read to read_u32_array Message-ID: <20211005090553.zoqzzz4767srvwzb@maple.lan> References: <20211004192741.621870-1-marijn.suijten@somainline.org> <20211004192741.621870-2-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211004192741.621870-2-marijn.suijten@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Oct 04, 2021 at 09:27:32PM +0200, Marijn Suijten wrote: > of_property_read_u32_array takes the number of elements to read as last > argument. This does not always need to be 4 (sizeof(u32)) but should > instead be the size of the array in DT as read just above with > of_property_count_elems_of_size. > > To not make such an error go unnoticed again the driver now bails > accordingly when of_property_read_u32_array returns an error. > > Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3") > Signed-off-by: Marijn Suijten > Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/qcom-wled.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > index d094299c2a48..6af808af2328 100644 > --- a/drivers/video/backlight/qcom-wled.c > +++ b/drivers/video/backlight/qcom-wled.c > @@ -1528,11 +1528,18 @@ static int wled_configure(struct wled *wled) > string_len = of_property_count_elems_of_size(dev->of_node, > "qcom,enabled-strings", > sizeof(u32)); > - if (string_len > 0) > - of_property_read_u32_array(dev->of_node, > + if (string_len > 0) { > + rc = of_property_read_u32_array(dev->of_node, > "qcom,enabled-strings", > wled->cfg.enabled_strings, > - sizeof(u32)); > + string_len); > + if (rc) { > + dev_err(dev, "Failed to read %d elements from " > + "qcom,enabled-strings: %d\n", > + string_len, rc); > + return -EINVAL; > + } > + } > > return 0; > } > -- > 2.33.0 >