From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47AE4C433F5 for ; Tue, 5 Oct 2021 09:21:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 291F2615A4 for ; Tue, 5 Oct 2021 09:21:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233608AbhJEJXP (ORCPT ); Tue, 5 Oct 2021 05:23:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233746AbhJEJXO (ORCPT ); Tue, 5 Oct 2021 05:23:14 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 524A4C061755 for ; Tue, 5 Oct 2021 02:21:24 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id s15so7940850wrv.11 for ; Tue, 05 Oct 2021 02:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YyFRyEHqynJbmWmKpAdZjz+T5rvFi/tpprXJLcyRG+c=; b=zU6qTFB44YrqG7QPOsXyenlqdjTTnsITuNv4caDgpwMUfUfDza4ur1dItnA+o5tCes BABj0CwihjxhMiEdeRqfM6eeHaNAJu/wLcb+30V83CgVz3MiPZNuT4JJKieDuqWj0iiX HPFdKAz3Vb0jzuzfvLnA9IhCPn5vBxXkprMTYCB/Fezv02qH9csTJlqzipGQsHtFckzV q3ek74KvDAO+ZHK5DEfC49BwDZDX6YF065rWYDXU9sR4UI5q33IMFUMLHdpZp84I8SUp fhYUq1lL0T01Y5DJl0yf2qDytTHBQMzDOhPTTBv6hbHbYoNemG+UzYKdAL3w8MvYjbfd ABzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YyFRyEHqynJbmWmKpAdZjz+T5rvFi/tpprXJLcyRG+c=; b=8Eayq8yDh+nz2840Ljrq5LF71M5tgcuukOyfc3/aK8wGIvvP0+V1HcGxt1idC8+9PL 30SE0ndfMppQRSzqvkd6b754B6H8kvOFExmDEF71GtFp9QFccWkJhPpLvaNA/6CvM4aH bxUQgl14SpGRqWmdVIne1thKBCHTpiN6iJZWqgesELXMX0H4AhmT5DKG6lBNG3zScFtT Ccbp4UaHQv7pIb2lJC4u5p0epjId4ONxmlD8lpal08RS7TtdsXyQhjoU+qwIxLtGDaEx I90JgVc0GKpvqVtsj/FADvXDWWEJegHeae+0yNnLjm8zQ6bSmA8fGJ0OV2v93xMvDzpb 48OQ== X-Gm-Message-State: AOAM532Gvn5C8hb1wZ+8quwAGo3QSndvFvT9pFP2D+VsWUWS0AaYNtr9 HY/fRoECbhCP7rYp0Z0E0aG9gQ== X-Google-Smtp-Source: ABdhPJxGEywgmrBoEZ6DWLGsjAD6iNKNcElVuvD49frLRb7/uaoZeADnEzDGMaHNCxL23n45nw/LPg== X-Received: by 2002:a5d:55c3:: with SMTP id i3mr20343391wrw.87.1633425682881; Tue, 05 Oct 2021 02:21:22 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id n186sm1266882wme.31.2021.10.05.02.21.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 02:21:22 -0700 (PDT) Date: Tue, 5 Oct 2021 10:21:20 +0100 From: Daniel Thompson To: Marijn Suijten Cc: phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Lee Jones , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Courtney Cavin , Bryan Wu , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/10] backlight: qcom-wled: Provide enabled_strings default for wled 4 and 5 Message-ID: <20211005092120.pe3z6jzs4bzc2zrx@maple.lan> References: <20211004192741.621870-1-marijn.suijten@somainline.org> <20211004192741.621870-8-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211004192741.621870-8-marijn.suijten@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Oct 04, 2021 at 09:27:38PM +0200, Marijn Suijten wrote: > Only wled 3 sets a sensible default that allows operating this driver > with just qcom,num-strings in the DT; wled 4 and 5 require > qcom,enabled-strings to be provided otherwise enabled_strings remains > zero-initialized, resuling in every string-specific register write > (currently only the setup and config functions, brightness follows in a > future patch) to only configure the zero'th string multiple times. > > Signed-off-by: Marijn Suijten > Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Daniel Thompson