From: Cai Huoqing <caihuoqing@baidu.com>
To: <caihuoqing@baidu.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
Vladimir Zapolskiy <vz@mleia.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Andy Gross <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-amlogic@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-rockchip@lists.infradead.org>
Subject: [PATCH v4 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe()
Date: Fri, 8 Oct 2021 17:28:55 +0800 [thread overview]
Message-ID: <20211008092858.495-7-caihuoqing@baidu.com> (raw)
In-Reply-To: <20211008092858.495-1-caihuoqing@baidu.com>
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
BTW, change the return value from 'ENXIO' to 'ENODEV',
perfer ENODEV which means no such device.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
v2->v3: Update the changelog.
drivers/iio/adc/qcom-pm8xxx-xoadc.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/adc/qcom-pm8xxx-xoadc.c b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
index 0610bf254771..21d7eff645c3 100644
--- a/drivers/iio/adc/qcom-pm8xxx-xoadc.c
+++ b/drivers/iio/adc/qcom-pm8xxx-xoadc.c
@@ -910,16 +910,15 @@ static int pm8xxx_xoadc_probe(struct platform_device *pdev)
map = dev_get_regmap(dev->parent, NULL);
if (!map) {
dev_err(dev, "parent regmap unavailable.\n");
- return -ENXIO;
+ return -ENODEV;
}
adc->map = map;
/* Bring up regulator */
adc->vref = devm_regulator_get(dev, "xoadc-ref");
- if (IS_ERR(adc->vref)) {
- dev_err(dev, "failed to get XOADC VREF regulator\n");
- return PTR_ERR(adc->vref);
- }
+ if (IS_ERR(adc->vref))
+ return dev_err_probe(dev, PTR_ERR(adc->vref),
+ "failed to get XOADC VREF regulator\n");
ret = regulator_enable(adc->vref);
if (ret) {
dev_err(dev, "failed to enable XOADC VREF regulator\n");
--
2.25.1
next prev parent reply other threads:[~2021-10-08 9:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 9:28 [PATCH v4 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
2021-10-08 9:28 ` [PATCH v4 2/9] iio: adc: imx7d_adc: " Cai Huoqing
2021-10-08 9:28 ` [PATCH v4 3/9] iio: adc: lpc18xx_adc: " Cai Huoqing
2021-10-08 9:28 ` [PATCH v4 4/9] iio: adc: max1118: " Cai Huoqing
2021-10-08 9:28 ` [PATCH v4 5/9] iio: adc: max1241: " Cai Huoqing
2021-10-08 9:28 ` [PATCH v4 6/9] iio: adc: meson_saradc: " Cai Huoqing
2021-10-10 16:05 ` Jonathan Cameron
2021-10-08 9:28 ` Cai Huoqing [this message]
2021-10-08 9:28 ` [PATCH v4 8/9] iio: adc: rockchip_saradc: " Cai Huoqing
2021-10-08 9:28 ` [PATCH v4 9/9] iio: adc: ti-ads7950: " Cai Huoqing
2021-10-17 11:54 ` [PATCH v4 1/9] iio: adc: ab8500-gpadc: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211008092858.495-7-caihuoqing@baidu.com \
--to=caihuoqing@baidu.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).