From: Claudio Suarez <cssk@net-c.es>
To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-tegra@vger.kernel.org, intel-gfx@lists.freedesktop.org,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan Xinhui" <Xinhui.Pan@amd.com>,
"Emma Anholt" <emma@anholt.net>,
"Maxime Ripard" <mripard@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Rob Clark" <robdclark@gmail.com>, "Sean Paul" <sean@poorly.run>,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
"Chen-Yu Tsai" <wens@csie.org>,
"Sandy Huang" <hjc@rock-chips.com>,
heiko@sntech.de, "Neil Armstrong" <narmstrong@baylibre.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Ben Skeggs" <bskeggs@redhat.com>,
nouveau@lists.freedesktop.org, ville.syrjala@linux.intel.com
Cc: Claudio Suarez <cssk@net-c.es>
Subject: [PATCH v2 02/13] drm/vc4: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi
Date: Sat, 16 Oct 2021 20:42:15 +0200 [thread overview]
Message-ID: <20211016184226.3862-3-cssk@net-c.es> (raw)
In-Reply-To: <20211016184226.3862-1-cssk@net-c.es>
Once EDID is parsed, the monitor HDMI support information is available
through drm_display_info.is_hdmi. Use this value instead of calling
drm_detect_hdmi_monitor() to avoid a second parse.
This is a TODO task in Documentation/gpu/todo.rst
Signed-off-by: Claudio Suarez <cssk@net-c.es>
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index b4b4653fe301..d531e4c501eb 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -182,7 +182,8 @@ vc4_hdmi_connector_detect(struct drm_connector *connector, bool force)
if (edid) {
cec_s_phys_addr_from_edid(vc4_hdmi->cec_adap, edid);
- vc4_hdmi->encoder.hdmi_monitor = drm_detect_hdmi_monitor(edid);
+ vc4_hdmi->encoder.hdmi_monitor =
+ connector->display_info.is_hdmi;
kfree(edid);
}
}
@@ -212,10 +213,9 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
if (!edid)
return -ENODEV;
- vc4_encoder->hdmi_monitor = drm_detect_hdmi_monitor(edid);
-
drm_connector_update_edid_property(connector, edid);
ret = drm_add_edid_modes(connector, edid);
+ vc4_encoder->hdmi_monitor = connector->display_info.is_hdmi;
kfree(edid);
if (vc4_hdmi->disable_4kp60) {
--
2.33.0
next prev parent reply other threads:[~2021-10-16 18:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 18:42 [PATCH v2 00/13] replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi Claudio Suarez
2021-10-16 18:42 ` [PATCH v2 01/13] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info Claudio Suarez
2021-10-19 18:35 ` Ville Syrjälä
2021-10-19 22:40 ` Claudio Suarez
2021-10-19 22:49 ` [PATCH v3 " Claudio Suarez
2021-10-16 18:42 ` Claudio Suarez [this message]
2021-10-16 18:42 ` [PATCH v2 03/13] drm/radeon: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi Claudio Suarez
2021-10-16 18:42 ` [PATCH v2 04/13] drm/tegra: " Claudio Suarez
2021-10-16 18:42 ` [PATCH v2 05/13] drm/gma500: " Claudio Suarez
2021-10-16 18:42 ` [PATCH v2 06/13] drm/exynos: " Claudio Suarez
2021-10-26 22:28 ` Inki Dae
2021-11-02 12:34 ` Claudio Suarez
2021-10-16 18:42 ` [PATCH v2 07/13] drm/msm: " Claudio Suarez
2021-11-25 13:26 ` Dmitry Baryshkov
2021-10-16 18:42 ` [PATCH v2 08/13] drm/sun4i: " Claudio Suarez
2021-10-16 18:42 ` [PATCH v2 09/13] drm/sti: " Claudio Suarez
2021-10-16 18:42 ` [PATCH v2 10/13] drm/rockchip: " Claudio Suarez
2021-10-16 18:42 ` [PATCH v2 11/13] drm/bridge: " Claudio Suarez
2021-10-16 18:42 ` [PATCH v2 12/13] drm/nouveau: " Claudio Suarez
2021-10-16 18:42 ` [PATCH v2 13/13] drm/i915: " Claudio Suarez
2021-10-19 18:37 ` Ville Syrjälä
2021-10-19 22:51 ` [PATCH v3 " Claudio Suarez
2021-10-21 13:49 ` Ville Syrjälä
2021-10-22 10:25 ` Claudio Suarez
2021-10-22 12:01 ` Ville Syrjälä
2021-10-22 12:22 ` [Intel-gfx] " Ville Syrjälä
2021-10-24 22:17 ` Claudio Suarez
2021-11-02 12:56 ` Claudio Suarez
2021-11-02 13:00 ` [PATCH v4 " Claudio Suarez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016184226.3862-3-cssk@net-c.es \
--to=cssk@net-c.es \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=freedreno@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jingoohan1@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=nouveau@lists.freedesktop.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=robdclark@gmail.com \
--cc=robert.foss@linaro.org \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
--cc=thierry.reding@gmail.com \
--cc=ville.syrjala@linux.intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).