From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EC4DC43219 for ; Wed, 24 Nov 2021 17:57:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350094AbhKXSAp (ORCPT ); Wed, 24 Nov 2021 13:00:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350074AbhKXSAo (ORCPT ); Wed, 24 Nov 2021 13:00:44 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42B59C06173E for ; Wed, 24 Nov 2021 09:57:34 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id o19-20020a1c7513000000b0033a93202467so2796924wmc.2 for ; Wed, 24 Nov 2021 09:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tTRniNEPYmBqX+RzY8diZyg3SNhaKQj2teILOgUmFAs=; b=LDHnPvGYoKgaaGUIJ4Vfd81Y9ikJGHVQFDZd9cUjBYb8M58QzYsQ/WHpjD4lE4Wvw+ L29Ef4ABBAJaiIY6Xz3rm8BvlBaGpa99KD1c9mtbexGQ3FlMXLZByASPukf6ibIwq1MJ cwL72UUhDpM3FT/wFrBkSSrl4BZ+CSRb8kVnLSCCQZJ7pAt9flSeFEEYFlxiwAsgTXGs 1+HGKaceeE2kEsFqMB7hKL0e9UwUIjp6NBAJU5FhVAjlSCuVcMyTGcCuIFh2MU0diBZN 8YiBS2eP+4RY42xB9RqReLZdR2i9Dq01/Q19EoWxufJ3QLqFu5sFtnjVmgqS6t7NwZ2R i8hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tTRniNEPYmBqX+RzY8diZyg3SNhaKQj2teILOgUmFAs=; b=LsyBfPx7mGU7fEAZGeN8yx5KihU+75U8BSj/Jvc0+sNzfBrgIOLsItPJ8IPGf/FxIu aPCm0MBxpza9GZ+1gHLmSNqkLdASJ6OtYsaMb6hkg6iir5pffFtc/AJhwJFwcVpWl6pk T5g+gKgntrOIZOtwb0Ohl8yWwjW/CjWjlIXg896PU4AEmOnx/0eT089sZ/kzN4tzu6F1 fflGPCwanVcyutwcVvpd9D1ObGaXuKweM18Lc4wK/FqSFKnsnlqH8OlpQMXe3y2MxCZE EW045FjQbSQRaM4hKYJMChxx67MrAF0M/4MzJjpKdOfPtR2kAmpEct8H7NoUNHVC4EMN xBUg== X-Gm-Message-State: AOAM532oxfBuXM3tQEhTyBVb/lRC5RD5PUYCF9WvWKwhAwIdzUyvJ23p EKJdCqt2/By/yjsuqE41keYcmrJKTROqB7zL X-Google-Smtp-Source: ABdhPJynSLq98UfafS4jwCbp9bxeIqmXkapb152eF2j11X0tsl0zUiZIRLGmmR+qfE2AZc7GQHNXhQ== X-Received: by 2002:a05:600c:1e87:: with SMTP id be7mr17418690wmb.182.1637776652586; Wed, 24 Nov 2021 09:57:32 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id s24sm380576wmj.26.2021.11.24.09.57.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 09:57:32 -0800 (PST) From: Bryan O'Donoghue To: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, robert.foss@linaro.org, jonathan@marek.ca Cc: andrey.konovalov@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, mchehab@kernel.org, jgrahsl@snap.com, hfink@snap.com, bryan.odonoghue@linaro.org Subject: [PATCH v2 13/19] media: camss: vfe-170: fix "VFE halt timeout" error Date: Wed, 24 Nov 2021 17:59:15 +0000 Message-Id: <20211124175921.1048375-14-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211124175921.1048375-1-bryan.odonoghue@linaro.org> References: <20211124175921.1048375-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Jonathan Marek This function waits for halt_complete but doesn't do anything to cause it to complete, and always hits the "VFE halt timeout" error. Just delete this code for now. Fixes: 7319cdf189bb ("media: camss: Add support for VFE hardware version Titan 170") Signed-off-by: Jonathan Marek Reviewed-by: Robert Foss Tested-by: Julian Grahsl Tested-by: Bryan O'Donoghue Signed-off-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss-vfe-170.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-vfe-170.c b/drivers/media/platform/qcom/camss/camss-vfe-170.c index 5c083d70d495..af71dc659bb9 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-170.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-170.c @@ -402,17 +402,7 @@ static irqreturn_t vfe_isr(int irq, void *dev) */ static int vfe_halt(struct vfe_device *vfe) { - unsigned long time; - - reinit_completion(&vfe->halt_complete); - - time = wait_for_completion_timeout(&vfe->halt_complete, - msecs_to_jiffies(VFE_HALT_TIMEOUT_MS)); - if (!time) { - dev_err(vfe->camss->dev, "VFE halt timeout\n"); - return -EIO; - } - + /* rely on vfe_disable_output() to stop the VFE */ return 0; } -- 2.33.0