linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: <agross@kernel.org>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>, <robh+dt@kernel.org>, <tglx@linutronix.de>,
	<maz@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <manivannan.sadhasivam@linaro.org>,
	Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH v5 6/6] dt-bindings: clock: Introduce pdc bindings for SDX65
Date: Wed, 1 Dec 2021 14:26:38 -0800	[thread overview]
Message-ID: <20211201222638.GB586@quicinc.com> (raw)
In-Reply-To: <YaF2eBKMkIvGapCY@ripper>

On Fri, Nov 26, 2021 at 04:06:16PM -0800, Bjorn Andersson wrote:
> On Thu 18 Nov 22:11 PST 2021, quic_vamslank@quicinc.com wrote:
> 
> > From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> > 
> > Add compatible for SDX65 pdc.
> > 
> > Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Acked-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Vinod Koul <vkoul@kernel.org>
> 
> Sorry for not spotting this before, but as you can tell from the path of
> the file you're changing, this has nothing to do with "clocks".
> 
> git log on qcom,pdc.txt shows that $subject should be:
> 
>   dt-bindings: qcom,pdc: Add compatible for SDX65
> 
> Also, as this is unrelated to clocks, Stephen is not going to merge this
> patch. You will have to repost it, with Marc Zyngier as recipient to get
> it merged; per get_maintainer.
> 
> 
> I think it's fine to keep the reviews and acks while adjusting $subject
> and reposting this patch  - separate from the other 5 patches.

Thank you for the review. Will repost this as a new patch.

Thanks,
Vamsi
> 
> Thanks,
> Bjorn
> 
> > ---
> >  .../devicetree/bindings/interrupt-controller/qcom,pdc.txt        | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> > index 98d89e53013d..ce631d853db4 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> > @@ -23,6 +23,7 @@ Properties:
> >  		    - "qcom,sdm845-pdc": For SDM845
> >  		    - "qcom,sdm8250-pdc": For SM8250
> >  		    - "qcom,sdm8350-pdc": For SM8350
> > +		    - "qcom,sdx65-pdc": For SDX65
> >  
> >  - reg:
> >  	Usage: required
> > -- 
> > 2.33.1
> > 

      reply	other threads:[~2021-12-01 22:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  6:11 [PATCH v5 0/6] Add Pdc, GCC and RPMh clock support for SDX65 quic_vamslank
2021-11-19  6:11 ` [PATCH v5 1/6] dt-bindings: clock: Add SDX65 GCC clock bindings quic_vamslank
2021-11-22 10:42   ` Vinod Koul
2021-11-28 23:14   ` Rob Herring
2021-11-19  6:11 ` [PATCH v5 2/6] clk: qcom: Add LUCID_EVO PLL type for SDX65 quic_vamslank
2021-11-22 10:42   ` Vinod Koul
2021-11-26 23:59   ` Bjorn Andersson
2021-11-19  6:11 ` [PATCH v5 3/6] clk: qcom: Add SDX65 GCC support quic_vamslank
2021-11-27  0:02   ` Bjorn Andersson
2021-11-19  6:11 ` [PATCH v5 4/6] dt-bindings: clock: Introduce RPMHCC bindings for SDX65 quic_vamslank
2021-11-19  6:11 ` [PATCH v5 5/6] clk: qcom: Add support for SDX65 RPMh clocks quic_vamslank
2021-11-19  6:11 ` [PATCH v5 6/6] dt-bindings: clock: Introduce pdc bindings for SDX65 quic_vamslank
2021-11-27  0:06   ` Bjorn Andersson
2021-12-01 22:26     ` Vamsi Krishna Lanka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211201222638.GB586@quicinc.com \
    --to=quic_vamslank@quicinc.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=maz@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).