linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rob Clark <robdclark@gmail.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Saravana Kannan <saravanak@google.com>
Subject: [PATCH v4 04/34] component: Move struct aggregate_device out to header file
Date: Thu,  2 Dec 2021 14:27:02 -0800	[thread overview]
Message-ID: <20211202222732.2453851-5-swboyd@chromium.org> (raw)
In-Reply-To: <20211202222732.2453851-1-swboyd@chromium.org>

This allows aggregate driver writers to use the device passed to their
probe/remove/shutdown functions properly instead of treating it as an
opaque pointer.

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Saravana Kannan <saravanak@google.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 drivers/base/component.c  | 15 ---------------
 include/linux/component.h | 19 ++++++++++++++++---
 2 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/drivers/base/component.c b/drivers/base/component.c
index eec82caeae5e..dc38a8939ae6 100644
--- a/drivers/base/component.c
+++ b/drivers/base/component.c
@@ -56,21 +56,6 @@ struct component_match {
 	struct component_match_array *compare;
 };
 
-struct aggregate_device {
-	const struct component_master_ops *ops;
-	struct device *parent;
-	struct device dev;
-	struct component_match *match;
-	struct aggregate_driver *adrv;
-
-	int id;
-};
-
-static inline struct aggregate_device *to_aggregate_device(struct device *d)
-{
-	return container_of(d, struct aggregate_device, dev);
-}
-
 struct component {
 	struct list_head node;
 	struct aggregate_device *adev;
diff --git a/include/linux/component.h b/include/linux/component.h
index 95d1b23ede8a..e99cf8e910f0 100644
--- a/include/linux/component.h
+++ b/include/linux/component.h
@@ -5,6 +5,8 @@
 #include <linux/stddef.h>
 #include <linux/device.h>
 
+struct component_match;
+
 /**
  * struct component_ops - callbacks for component drivers
  *
@@ -39,8 +41,6 @@ void component_del(struct device *, const struct component_ops *);
 int component_bind_all(struct device *master, void *master_data);
 void component_unbind_all(struct device *master, void *master_data);
 
-struct aggregate_device;
-
 /**
  * struct component_master_ops - callback for the aggregate driver
  *
@@ -80,7 +80,20 @@ struct component_master_ops {
 	void (*unbind)(struct device *master);
 };
 
-struct component_match;
+struct aggregate_device {
+	const struct component_master_ops *ops;
+	struct device *parent;
+	struct device dev;
+	struct component_match *match;
+	struct aggregate_driver *adrv;
+
+	int id;
+};
+
+static inline struct aggregate_device *to_aggregate_device(struct device *d)
+{
+	return container_of(d, struct aggregate_device, dev);
+}
 
 /**
  * struct aggregate_driver - Aggregate driver (made up of other drivers)
-- 
https://chromeos.dev


  parent reply	other threads:[~2021-12-02 22:27 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02 22:26 [PATCH v4 00/34] component: Make into an aggregate bus Stephen Boyd
2021-12-02 22:26 ` [PATCH v4 01/34] component: Introduce struct aggregate_device Stephen Boyd
2021-12-21  9:28   ` Greg Kroah-Hartman
2022-01-06  2:11     ` Stephen Boyd
2021-12-21  9:29   ` Greg Kroah-Hartman
2022-01-06  2:17     ` Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 02/34] component: Remove most references to 'master' Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 03/34] component: Introduce the aggregate bus_type Stephen Boyd
2021-12-02 22:27 ` Stephen Boyd [this message]
2021-12-02 22:27 ` [PATCH v4 05/34] component: Add {bind,unbind}_component() ops that take aggregate device Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 06/34] drm/of: Add a drm_of_aggregate_probe() API Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 07/34] drm/msm: Migrate to aggregate driver Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 08/34] drm/komeda: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 09/34] drm/arm/hdlcd: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 10/34] drm/malidp: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 11/34] drm/armada: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 12/34] drm/etnaviv: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 13/34] drm/kirin: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 14/34] drm/exynos: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 15/34] drm/imx: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 16/34] drm/ingenic: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 17/34] drm/mcde: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 18/34] drm/mediatek: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 19/34] drm/meson: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 20/34] drm/omap: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 21/34] drm/rockchip: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 22/34] drm/sti: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 23/34] drm/sun4i: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 24/34] drm/tilcdc: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 25/34] drm/vc4: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 26/34] iommu/mtk: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 27/34] mei: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 28/34] power: supply: ab8500: " Stephen Boyd
2021-12-03  1:50   ` Linus Walleij
2021-12-02 22:27 ` [PATCH v4 29/34] fbdev: omap2: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 30/34] sound: hdac: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 31/34] ASoC: codecs: wcd938x: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 32/34] mei: pxp: " Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 33/34] component: Get rid of drm_of_component_probe() Stephen Boyd
2021-12-02 22:27 ` [PATCH v4 34/34] component: Remove component_master_ops and friends Stephen Boyd
2021-12-03  1:51 ` [PATCH v4 00/34] component: Make into an aggregate bus Linus Walleij
2021-12-07 18:22 ` Daniel Vetter
2021-12-13 21:43   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211202222732.2453851-5-swboyd@chromium.org \
    --to=swboyd@chromium.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=robdclark@gmail.com \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).