From: Guo Zhengkui <guozhengkui@vivo.com>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT),
linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK),
linux-kernel@vger.kernel.org (open list)
Cc: kernel@vivo.com, Guo Zhengkui <guozhengkui@vivo.com>
Subject: [PATCH] phy: qcom: use struct_size instead of sizeof
Date: Thu, 9 Dec 2021 11:21:14 +0800 [thread overview]
Message-ID: <20211209032114.9416-1-guozhengkui@vivo.com> (raw)
In-Reply-To: <20211207131642.5313-1-guozhengkui@vivo.com>
Use struct_size() to get the accurate size of `clk_hw_onecell_data`
with a variable size array, instead of sizeof(data) to get the size
of a pointer.
Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
drivers/phy/qualcomm/phy-qcom-edp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
index 17d5653b661d..a8ecd2e8442d 100644
--- a/drivers/phy/qualcomm/phy-qcom-edp.c
+++ b/drivers/phy/qualcomm/phy-qcom-edp.c
@@ -571,7 +571,7 @@ static int qcom_edp_clks_register(struct qcom_edp *edp, struct device_node *np)
struct clk_init_data init = { };
int ret;
- data = devm_kzalloc(edp->dev, sizeof(data), GFP_KERNEL);
+ data = devm_kzalloc(edp->dev, struct_size(data, hws, 2), GFP_KERNEL);
if (!data)
return -ENOMEM;
--
2.20.1
next prev parent reply other threads:[~2021-12-09 3:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 13:16 [PATCH] phy: qcom: fix bug: application of sizeof to pointer Guo Zhengkui
2021-12-07 15:13 ` Bjorn Andersson
[not found] ` <AO6AKgBME5Y4PNQLIg0Wlap9.9.1638889943341.Hmail.guozhengkui@vivo.com.@PFlhOTZLT3luc080NzhjVnhAcmlwcGVyPg==>
2021-12-08 6:56 ` Guo Zhengkui
2021-12-08 16:29 ` Bjorn Andersson
2021-12-09 3:21 ` Guo Zhengkui [this message]
2021-12-09 4:50 ` [PATCH] phy: qcom: use struct_size instead of sizeof Bjorn Andersson
2021-12-09 11:55 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211209032114.9416-1-guozhengkui@vivo.com \
--to=guozhengkui@vivo.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=kernel@vivo.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).