linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Caleb Connolly <caleb.connolly@linaro.org>
To: caleb.connolly@linaro.org, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Lee Jones <lee.jones@linaro.org>, Stephen Boyd <sboyd@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: Jami Kettunen <jami.kettunen@somainline.org>,
	Sumit Semwal <sumit.semwal@linaro.org>
Subject: [PATCH v14 00/10] iio: adc: introduce Qualcomm SPMI Round Robin ADC
Date: Fri, 29 Apr 2022 23:08:55 +0100	[thread overview]
Message-ID: <20220429220904.137297-1-caleb.connolly@linaro.org> (raw)

The RRADC is responsible for reading data about the current and
voltage from the USB or DC in jacks, it can also read the battery
ID (resistence) and some temperatures. It is found on the PMI8998 and
PM660 Qualcomm PMICs.

The RRADC has to calibrate some ADC values based on which chip fab
the PMIC was produced in, to facilitate this the patches
("mfd: qcom-spmi-pmic: expose the PMIC revid information to clients")
and ("mfd: qcom-spmi-pmic: read fab id on supported PMICs")
expose the PMIC revision information and fab_id as a struct and register
them as driver data in the Qualcomm SPMI PMIC driver so that it can be
read by the RRADC.

The first 3 patches add support for looking up an SPMI device from a
struct device_node, as well as introducing support for looking up the
base USID of a Qcom PMIC, see patch comments for more details. These
Address Bjorns comments on v2.

Changes since v13:
 * Address Lee Jones' feedback on the SPMI patches.
 * Pick up Jami's patch to enable the RRADC on the OnePlus 5

Changes since v12:
 * Apply Krzysztof's suggestions to rradc DT binding docs.

Changes since v11:
 * Remove debug logging which was left in ("mfd: qcom-spmi-pmic: expose the PMIC revid information to clients")
 * Picked up Dmitry's Tested-by and Reviewed-by tags.

Changes since v10:
 * Don't inline spmi_device_from_of()

Changes since v9:
 * Add back missing copyright, this driver is originally derived from
   downstream (Thanks Manivannan).

Changes since v8:
 * Drop Reported-by for the bugfix on previous revision reported by LKP
 * Apply Jonathans suggestions
 * Rework patch 2 ("expose the PMIC revid information to clients") to
   handle PMICs with a single USID (thanks Dmitry)

Changes since v7:
 * Addressed Jonathans comments
 * Fixed bug reported by LKP

Changes since v6:
 * Fix printf format warning in rradc

Changes since v5:
 * Add missing EXPORT_SYMBOL_GPL() to
   ("spmi: add a helper to look up an SPMI device from a device node")

Changes since v4:
 * Addressed Jonathan's comments on v4
 * Reworked the qcom-spmi-pmic patches to properly walk the devicetree
   to find the base USID. I've tested this on SDM845 which has two PMICs
   (pm8998 and pmi8998) and I'm able to look up the PMIC revid from all
   4 USIDs.

Changes since v3:
 * Split PMIC patch in two, rework to support function drivers on a
   sibling USID
 * Completely rework RRADC driver to make use of the modern IIO
   framework. This required re-arranging a lot of the equations and
   results in some lost precision, where relevant I've left comments to
   explain this. I don't think any of it is significant enough to
   justify doing post-processing in driver.
   Thanks a lot Jonathan and John Stultz for helping me out with
   this

Changes since v2:
 * Add missing include (thanks kernel test robot :D)
 * Rework some confusing function return values, specifically
   rradc_read_status_in_cont_mode and rradc_prepare_batt_id_conversion
   both of which didn't correctly handle "ret". This also bought up an
   issue as the previous implementation didn't actually wait for the
   channel to be ready. It doesn't seem like that's strictly necessary
   (same data is reported if I wait for the status to be good or not)
   but I've included it anyway for good measure.

Changes since v1:
 * Rework the RRADC driver based on Jonathan's feedback
 * Pick up Rob's reviewed by for the dt-binding patch.
 ---
Caleb Connolly (9):
  spmi: add a helper to look up an SPMI device from a device node
  mfd: qcom-spmi-pmic: expose the PMIC revid information to clients
  mfd: qcom-spmi-pmic: read fab id on supported PMICs
  dt-bindings: iio: adc: document qcom-spmi-rradc
  iio: adc: qcom-spmi-rradc: introduce round robin adc
  arm64: dts: qcom: pmi8998: add rradc node
  arm64: dts: qcom: sdm845-oneplus: enable rradc
  arm64: dts: qcom: sdm845-db845c: enable rradc
  arm64: dts: qcom: sdm845-xiaomi-beryllium: enable rradc

Jami Kettunen (1):
  arm64: dts: qcom: msm8998-oneplus-common: enable RRADC

 .../bindings/iio/adc/qcom,spmi-rradc.yaml     |   51 +
 .../boot/dts/qcom/msm8998-oneplus-common.dtsi |    4 +
 arch/arm64/boot/dts/qcom/pmi8998.dtsi         |    8 +
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts    |    4 +
 .../boot/dts/qcom/sdm845-oneplus-common.dtsi  |    4 +
 .../boot/dts/qcom/sdm845-xiaomi-beryllium.dts |    4 +
 drivers/iio/adc/Kconfig                       |   12 +
 drivers/iio/adc/Makefile                      |    1 +
 drivers/iio/adc/qcom-spmi-rradc.c             | 1021 +++++++++++++++++
 drivers/mfd/qcom-spmi-pmic.c                  |  272 +++--
 drivers/spmi/spmi.c                           |   17 +
 include/linux/spmi.h                          |    3 +
 include/soc/qcom/qcom-spmi-pmic.h             |   61 +
 13 files changed, 1372 insertions(+), 90 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml
 create mode 100644 drivers/iio/adc/qcom-spmi-rradc.c
 create mode 100644 include/soc/qcom/qcom-spmi-pmic.h

-- 
2.36.0


             reply	other threads:[~2022-04-29 22:10 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 22:08 Caleb Connolly [this message]
2022-04-29 22:08 ` [PATCH v14 01/10] spmi: add a helper to look up an SPMI device from a device node Caleb Connolly
2022-05-01 17:23   ` Jonathan Cameron
2022-06-04 16:29     ` Jonathan Cameron
2022-06-14  8:40   ` Stephen Boyd
2022-04-29 22:08 ` [PATCH v14 02/10] mfd: qcom-spmi-pmic: expose the PMIC revid information to clients Caleb Connolly
2022-05-01 17:28   ` Jonathan Cameron
2022-06-14 10:42     ` Jonathan Cameron
2022-06-15 21:41   ` Lee Jones
2022-06-18 12:58   ` Jonathan Cameron
2022-04-29 22:08 ` [PATCH v14 03/10] mfd: qcom-spmi-pmic: read fab id on supported PMICs Caleb Connolly
2022-06-15 21:40   ` Lee Jones
2022-04-29 22:08 ` [PATCH v14 04/10] dt-bindings: iio: adc: document qcom-spmi-rradc Caleb Connolly
2022-04-30 14:44   ` Krzysztof Kozlowski
2022-04-30 15:00     ` Caleb Connolly
2022-05-01  8:28   ` Krzysztof Kozlowski
2022-06-14 10:45   ` Jonathan Cameron
2022-04-29 22:09 ` [PATCH v14 05/10] iio: adc: qcom-spmi-rradc: introduce round robin adc Caleb Connolly
2022-05-01 17:38   ` Jonathan Cameron
2022-05-09 11:53     ` Caleb Connolly
2022-06-14 10:44       ` Jonathan Cameron
2022-04-29 22:09 ` [PATCH v14 06/10] arm64: dts: qcom: pmi8998: add rradc node Caleb Connolly
2022-04-29 22:09 ` [PATCH v14 07/10] arm64: dts: qcom: sdm845-oneplus: enable rradc Caleb Connolly
2022-04-29 22:09 ` [PATCH v14 08/10] arm64: dts: qcom: sdm845-db845c: " Caleb Connolly
2022-04-29 22:09 ` [PATCH v14 09/10] arm64: dts: qcom: sdm845-xiaomi-beryllium: " Caleb Connolly
2022-04-29 22:09 ` [PATCH v14 10/10] arm64: dts: qcom: msm8998-oneplus-common: enable RRADC Caleb Connolly
2022-06-18 13:09 ` [PATCH v14 00/10] iio: adc: introduce Qualcomm SPMI Round Robin ADC Jonathan Cameron
2022-06-18 13:17   ` Jonathan Cameron
2022-06-18 16:13     ` Caleb Connolly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220429220904.137297-1-caleb.connolly@linaro.org \
    --to=caleb.connolly@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jami.kettunen@somainline.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).