From: kernel test robot <lkp@intel.com>
To: Markuss Broks <markuss.broks@gmail.com>, linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Markuss Broks <markuss.broks@gmail.com>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Song Qiang <songqiang1304521@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/5] proximity: vl53l0x: Prefer already initialized interrupt flags
Date: Thu, 12 May 2022 18:32:25 +0800 [thread overview]
Message-ID: <202205121820.qRBa5PNP-lkp@intel.com> (raw)
In-Reply-To: <20220511214718.50879-3-markuss.broks@gmail.com>
Hi Markuss,
I love your patch! Yet something to improve:
[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on robh/for-next linux/master linus/master v5.18-rc6 next-20220511]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Markuss-Broks/Add-support-for-ToF-sensor-on-Yoshino-platform/20220512-054917
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: s390-randconfig-r032-20220509 (https://download.01.org/0day-ci/archive/20220512/202205121820.qRBa5PNP-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 18dd123c56754edf62c7042dcf23185c3727610f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/b4103f031e2c0265ae4f15f107341bcfc83008f0
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Markuss-Broks/Add-support-for-ToF-sensor-on-Yoshino-platform/20220512-054917
git checkout b4103f031e2c0265ae4f15f107341bcfc83008f0
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/iio/proximity/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/iio/proximity/vl53l0x-i2c.c:60:18: error: call to undeclared function 'irq_get_trigger_type'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
int irq_flags = irq_get_trigger_type(client->irq);
^
1 error generated.
vim +/irq_get_trigger_type +60 drivers/iio/proximity/vl53l0x-i2c.c
56
57 static int vl53l0x_configure_irq(struct i2c_client *client,
58 struct iio_dev *indio_dev)
59 {
> 60 int irq_flags = irq_get_trigger_type(client->irq);
61 struct vl53l0x_data *data = iio_priv(indio_dev);
62 int ret;
63
64 if (!irq_flags)
65 irq_flags = IRQF_TRIGGER_FALLING;
66
67 ret = devm_request_irq(&client->dev, client->irq, vl53l0x_handle_irq,
68 irq_flags, indio_dev->name, indio_dev);
69 if (ret) {
70 dev_err(&client->dev, "devm_request_irq error: %d\n", ret);
71 return ret;
72 }
73
74 ret = i2c_smbus_write_byte_data(data->client,
75 VL_REG_SYSTEM_INTERRUPT_CONFIG_GPIO,
76 VL_REG_SYSTEM_INTERRUPT_GPIO_NEW_SAMPLE_READY);
77 if (ret < 0)
78 dev_err(&client->dev, "failed to configure IRQ: %d\n", ret);
79
80 return ret;
81 }
82
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-05-12 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 21:47 [PATCH v2 0/5] Add support for ToF sensor on Yoshino platform Markuss Broks
2022-05-11 21:47 ` [PATCH v2 1/5] dt-bindings: proximity: vl53l0x: Document optional supply and GPIO properties Markuss Broks
2022-05-13 8:16 ` Krzysztof Kozlowski
2022-05-11 21:47 ` [PATCH v2 2/5] proximity: vl53l0x: Prefer already initialized interrupt flags Markuss Broks
2022-05-12 10:32 ` kernel test robot [this message]
2022-05-11 21:47 ` [PATCH v2 3/5] proximity: vl53l0x: Handle the VDD regulator Markuss Broks
2022-05-11 21:47 ` [PATCH v2 4/5] proximity: vl53l0x: Handle the reset GPIO Markuss Broks
2022-05-11 21:47 ` [PATCH v2 5/5] arm64: dts: qcom: msm8998-xperia: Introduce ToF sensor support Markuss Broks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205121820.qRBa5PNP-lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=marijn.suijten@somainline.org \
--cc=markuss.broks@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=songqiang1304521@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).