From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1888C433FE for ; Sun, 15 May 2022 14:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237267AbiEOOvO (ORCPT ); Sun, 15 May 2022 10:51:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237336AbiEOOvM (ORCPT ); Sun, 15 May 2022 10:51:12 -0400 Received: from relay06.th.seeweb.it (relay06.th.seeweb.it [IPv6:2001:4b7a:2000:18::167]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B714E1136 for ; Sun, 15 May 2022 07:51:11 -0700 (PDT) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 2AC8E3F64F; Sun, 15 May 2022 16:51:10 +0200 (CEST) Date: Sun, 15 May 2022 16:51:08 +0200 From: Marijn Suijten To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 07/12] arm64: dts: qcom: sdm630: fix gpu's interconnect path Message-ID: <20220515145108.zfmlb53vacx7sr33@SoMainline.org> References: <20220514190138.3179964-1-dmitry.baryshkov@linaro.org> <20220514190138.3179964-8-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220514190138.3179964-8-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2022-05-14 22:01:33, Dmitry Baryshkov wrote: > ICC path for the GPU incorrectly states <&gnoc 1 &bimc 5>, which is > a path from SLAVE_GNOC_BIMC to SLAVE_EBI. According to the downstream Nit: "the downstream" -> "downstream sources(,) the" > GPU uses MASTER_OXILI here, <&bimc 1 ...>. "here, which is equivalent to <&bimc 1 ...> [upstream/mainline/here]" > > Fixes: 5cf69dcbec8b ("arm64: dts: qcom: sdm630: Add Adreno 508 GPU configuration") > Reported-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten > --- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi > index 2b5dbc12bdf8..6d0bc9e8fb5b 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > @@ -1045,7 +1045,7 @@ adreno_gpu: gpu@5000000 { > nvmem-cells = <&gpu_speed_bin>; > nvmem-cell-names = "speed_bin"; > > - interconnects = <&gnoc 1 &bimc 5>; > + interconnects = <&bimc 1 &bimc 5>; > interconnect-names = "gfx-mem"; > > operating-points-v2 = <&gpu_sdm630_opp_table>; > -- > 2.35.1 >