From: Rob Herring <robh@kernel.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, quic_plai@quicinc.com,
bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com,
srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
judyhsiao@chromium.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
Date: Thu, 2 Jun 2022 09:32:45 -0500 [thread overview]
Message-ID: <20220602143245.GA2256965-robh@kernel.org> (raw)
In-Reply-To: <1654169206-12255-2-git-send-email-quic_srivasam@quicinc.com>
On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
> Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
> as MI2S mclk is being used is from lpass core cc.
This is safe to change breaking the ABI because ...
Names are supposed to be local to the module, not based on their source.
>
> Fixes: 98b7630a583f ("ASoC: dt-bindings: lpass-cpu: Update clocks and power domain names for sc7280 platform")
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> ---
> Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> index e9a5330..8438ef77 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> @@ -195,7 +195,7 @@ allOf:
> oneOf:
> - items: #for I2S
> - const: aon_cc_audio_hm_h
> - - const: audio_cc_ext_mclk0
> + - const: core_cc_ext_mclk0
> - const: core_cc_sysnoc_mport_core
> - const: core_cc_ext_if0_ibit
> - const: core_cc_ext_if1_ibit
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2022-06-02 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 11:26 [PATCH 0/2] Update external mclk name Srinivasa Rao Mandadapu
2022-06-02 11:26 ` [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name Srinivasa Rao Mandadapu
2022-06-02 14:32 ` Rob Herring [this message]
2022-06-02 14:40 ` Mark Brown
2022-06-13 10:55 ` Srinivasa Rao Mandadapu
2022-06-02 11:26 ` [PATCH 2/2] ASoC: qcom: lpass-sc7280: Update external mclk0 name Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602143245.GA2256965-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).