From: Marijn Suijten <marijn.suijten@somainline.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
jamipkettunen@somainline.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: rpmpd: Add SM6375 power domains
Date: Thu, 21 Jul 2022 11:59:46 +0200 [thread overview]
Message-ID: <20220721095946.wy3wbeib4ycwghzl@SoMainline.org> (raw)
In-Reply-To: <20220716193201.455728-1-konrad.dybcio@somainline.org>
On 2022-07-16 21:32:00, Konrad Dybcio wrote:
> Add the bindings for SM6375 RPMPDs.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
> include/dt-bindings/power/qcom-rpmpd.h | 12 ++++++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> index ad77a6380f38..8b58cbc298a1 100644
> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> @@ -39,6 +39,7 @@ properties:
> - qcom,sm6115-rpmpd
> - qcom,sm6125-rpmpd
> - qcom,sm6350-rpmhpd
> + - qcom,sm6375-rpmpd
> - qcom,sm8150-rpmhpd
> - qcom,sm8250-rpmhpd
> - qcom,sm8350-rpmhpd
> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> index 6cce5b7aa940..8b770bfcf46b 100644
> --- a/include/dt-bindings/power/qcom-rpmpd.h
> +++ b/include/dt-bindings/power/qcom-rpmpd.h
> @@ -36,6 +36,18 @@
> #define SM6350_MSS 4
> #define SM6350_MX 5
>
> +/* SM6350 Power Domain Indexes */
> +#define SM6375_VDDCX 0
> +#define SM6375_VDDCX_AO 1
> +#define SM6375_VDDCX_VFL 2
> +#define SM6375_VDDMX 3
> +#define SM6375_VDDMX_AO 4
> +#define SM6375_VDDMX_VFL 5
> +#define SM6375_VDDGX 6
> +#define SM6375_VDDGX_AO 7
> +#define SM6375_VDD_LPI_CX 8
> +#define SM6375_VDD_LPI_MX 9
Looking at the naming/pattern of these constants I think they should
reside near the bottom of this file with SM6125 and friends, rather than
here with SM8150 and friends' MX/CX (and no _VFL).
- Marijn
> /* SM8150 Power Domain Indexes */
> #define SM8150_MSS 0
> #define SM8150_EBI 1
> --
> 2.37.0
>
next prev parent reply other threads:[~2022-07-21 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 19:32 [PATCH 1/2] dt-bindings: power: rpmpd: Add SM6375 power domains Konrad Dybcio
2022-07-16 19:32 ` [PATCH 2/2] soc: qcom: rpmpd: Add SM6375 support Konrad Dybcio
2022-07-20 22:28 ` [PATCH 1/2] dt-bindings: power: rpmpd: Add SM6375 power domains Rob Herring
2022-07-21 9:59 ` Marijn Suijten [this message]
2022-09-15 3:36 ` (subset) " Bjorn Andersson
2022-09-16 22:04 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721095946.wy3wbeib4ycwghzl@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.botka@somainline.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).